mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 07/18] cdev: alias: add support for partition links
Date: Mon, 14 Apr 2025 08:31:41 +0200	[thread overview]
Message-ID: <20250414063152.2736649-8-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20250414063152.2736649-1-a.fatoum@pengutronix.de>

We currently support bootsource.2, but not bootsource.root-A.
Fix this and while at it, factor out the logic for general reuse.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 common/cdev-alias.c | 22 +++-------------------
 fs/devfs-core.c     | 29 +++++++++++++++++++++++++++++
 include/driver.h    |  1 +
 3 files changed, 33 insertions(+), 19 deletions(-)

diff --git a/common/cdev-alias.c b/common/cdev-alias.c
index 5c37c2e58bf3..09e6770f5dea 100644
--- a/common/cdev-alias.c
+++ b/common/cdev-alias.c
@@ -17,22 +17,6 @@ struct cdev_alias {
 		       cdev_alias_processor_t fn, void *data);
 };
 
-static struct cdev *resolve_partition(struct cdev *cdev,
-				      const char *partname)
-{
-	struct cdev *partcdev;
-
-	if (!partname)
-		return cdev;
-
-	for_each_cdev_partition(partcdev, cdev) {
-		if (streq_ptr(partcdev->partname, partname))
-			return partcdev;
-	}
-
-	return ERR_PTR(-ENODEV);
-}
-
 static int cdev_alias_resolve_bootsource(struct cdev_alias *cdev_alias,
 					 const char *partname,
 					 cdev_alias_processor_t fn,
@@ -44,9 +28,9 @@ static int cdev_alias_resolve_bootsource(struct cdev_alias *cdev_alias,
 	if (!cdev)
 		return -ENODEV;
 
-	cdev = resolve_partition(cdev, partname);
-	if (IS_ERR(cdev))
-		return PTR_ERR(cdev);
+	cdev = cdev_find_partition(cdev, partname);
+	if (!cdev)
+		return -ENODEV;
 
 	return fn(cdev, data);
 }
diff --git a/fs/devfs-core.c b/fs/devfs-core.c
index c69c38d6506e..e32bce9e307e 100644
--- a/fs/devfs-core.c
+++ b/fs/devfs-core.c
@@ -21,6 +21,7 @@
 #include <malloc.h>
 #include <ioctl.h>
 #include <nand.h>
+#include <string.h>
 #include <linux/err.h>
 #include <linux/fs.h>
 #include <linux/mtd/mtd.h>
@@ -149,6 +150,34 @@ cdev_find_child_by_gpt_typeuuid(struct cdev *cdev, const guid_t *typeuuid)
 	return ERR_PTR(-ENOENT);
 }
 
+/**
+ * cdev_find_partition - find a partition belonging to a physical device
+ *
+ * @cdev: the cdev which should be searched for partitions
+ * @name: the partition name
+ */
+struct cdev *cdev_find_partition(struct cdev *cdevm, const char *name)
+{
+	struct cdev *partcdev;
+
+	if (!name)
+		return cdevm;
+
+	for_each_cdev_partition(partcdev, cdevm) {
+		struct cdev *cdevl;
+
+		if (streq_ptr(partcdev->partname, name))
+			return partcdev;
+
+		list_for_each_entry(cdevl, &partcdev->links, link_entry) {
+			if (streq_ptr(cdevl->partname, name))
+				return cdevl;
+		}
+	}
+
+	return NULL;
+}
+
 /**
  * device_find_partition - find a partition belonging to a physical device
  *
diff --git a/include/driver.h b/include/driver.h
index 3f2c681c0e80..ca002c5164c2 100644
--- a/include/driver.h
+++ b/include/driver.h
@@ -503,6 +503,7 @@ int devfs_create(struct cdev *);
 int devfs_create_link(struct cdev *, const char *name);
 int devfs_remove(struct cdev *);
 int cdev_find_free_index(const char *);
+struct cdev *cdev_find_partition(struct cdev *cdevm, const char *name);
 struct cdev *device_find_partition(struct device *dev, const char *name);
 struct cdev *lcdev_by_name(const char *filename);
 struct cdev *cdev_readlink(struct cdev *cdev);
-- 
2.39.5




  parent reply	other threads:[~2025-04-14  6:32 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14  6:31 [PATCH 00/18] boot: improve cdev alias and blspec support Ahmad Fatoum
2025-04-14  6:31 ` [PATCH 01/18] cdev: make cdev_find_child_by_gpt_typeuuid external Ahmad Fatoum
2025-04-14  6:31 ` [PATCH 02/18] cdev: constify cdev_find_child_by_gpt_typeuuid's guid_t pointer argument Ahmad Fatoum
2025-04-14  6:31 ` [PATCH 03/18] partition: efi: respect DPS_TYPE_FLAG_NO_AUTO flag Ahmad Fatoum
2025-04-14 11:38   ` Sascha Hauer
2025-04-14  6:31 ` [PATCH 04/18] blspec: iterate over all XBOOTLDR partitions Ahmad Fatoum
2025-04-14  6:31 ` [PATCH 05/18] blspec: support GPT XBOOTLDR partition Ahmad Fatoum
2025-04-14  6:31 ` [PATCH 06/18] blspec: collect bootloader spec entries from ESP Ahmad Fatoum
2025-04-14 10:14   ` Marco Felsch
2025-04-14 10:19     ` Ahmad Fatoum
2025-04-14 10:41       ` Marco Felsch
2025-04-14  6:31 ` Ahmad Fatoum [this message]
2025-04-14 10:17   ` [PATCH 07/18] cdev: alias: add support for partition links Marco Felsch
2025-04-14 10:20     ` Ahmad Fatoum
2025-04-14 10:49       ` Marco Felsch
2025-04-14 13:28         ` Sascha Hauer
2025-04-14  6:31 ` [PATCH 08/18] cdev: do not dereference partname for non-partitions Ahmad Fatoum
2025-04-14  6:31 ` [PATCH 09/18] cdev: use common cdev_free helper internally Ahmad Fatoum
2025-04-14  6:31 ` [PATCH 10/18] cdev: implement devfs_create_link in terms of devfs_create Ahmad Fatoum
2025-04-14  6:31 ` [PATCH 11/18] misc: storage-by-uuid: consider only first diskuuid match Ahmad Fatoum
2025-04-14 10:24   ` Marco Felsch
2025-04-14 10:31     ` Ahmad Fatoum
2025-04-14  6:31 ` [PATCH 12/18] misc: storage-by-uuid: prepare for generalizing to different aliases Ahmad Fatoum
2025-04-14 10:31   ` Marco Felsch
2025-04-14 10:35     ` Ahmad Fatoum
2025-04-14  6:31 ` [PATCH 13/18] misc: storage-by-uuid: rename to storage-by-alias Ahmad Fatoum
2025-04-14  6:31 ` [PATCH 14/18] misc: storage-by-alias: switch over to using cdev aliases Ahmad Fatoum
2025-04-14  6:31 ` [PATCH 15/18] misc: storage-by-alias: add support barebox,bootsource Ahmad Fatoum
2025-04-14  6:31 ` [PATCH 16/18] misc: storage-by-alias: register as link to main cdev Ahmad Fatoum
2025-04-14  6:31 ` [PATCH 17/18] cdev: constify cdev_readlink argument Ahmad Fatoum
2025-04-14  6:31 ` [PATCH 18/18] cdev: follow links in cdev_find_child_by_gpt_typeuuid Ahmad Fatoum
2025-04-14 10:51 ` [PATCH 00/18] boot: improve cdev alias and blspec support Marco Felsch
2025-04-14 13:25 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250414063152.2736649-8-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox