Re: [PATCH 00/18] boot: improve cdev alias and blspec support

[Marco Felsch <m.felsch@pengutronix.de>]

Hi Ahmad,

On 25-04-14, Ahmad Fatoum wrote:
> Building on past top of past bootscan and cdev alias infrastructure in
> next, enable the following:
> 
>    - Favoring entries in GPT XBOOTLDR partition and EFI system
>      partitions, like we already do for MBR XBOOTLDR partition
> 
>    - Allow state backend and other DT bindings to point at a
>      barebox,bootsource node to allow same state DT description
>      to work across different boot media

thanks for your work :) The series LGTM with minor nits.

Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

Regards,
  Marco

> 
> Ahmad Fatoum (18):
>   cdev: make cdev_find_child_by_gpt_typeuuid external
>   cdev: constify cdev_find_child_by_gpt_typeuuid's guid_t pointer
>     argument
>   partition: efi: respect DPS_TYPE_FLAG_NO_AUTO flag
>   blspec: iterate over all XBOOTLDR partitions
>   blspec: support GPT XBOOTLDR partition
>   blspec: collect bootloader spec entries from ESP
>   cdev: alias: add support for partition links
>   cdev: do not dereference partname for non-partitions
>   cdev: use common cdev_free helper internally
>   cdev: implement devfs_create_link in terms of devfs_create
>   misc: storage-by-uuid: consider only first diskuuid match
>   misc: storage-by-uuid: prepare for generalizing to different aliases
>   misc: storage-by-uuid: rename to storage-by-alias
>   misc: storage-by-alias: switch over to using cdev aliases
>   misc: storage-by-alias: add support barebox,bootsource
>   misc: storage-by-alias: register as link to main cdev
>   cdev: constify cdev_readlink argument
>   cdev: follow links in cdev_find_child_by_gpt_typeuuid
> 
>  commands/boot.c                 |   1 +
>  common/blspec.c                 |  75 +++++++---
>  common/bootscan.c               |  11 +-
>  common/cdev-alias.c             |  53 ++++---
>  drivers/misc/Kconfig            |  21 ++-
>  drivers/misc/Makefile           |   2 +-
>  drivers/misc/storage-by-alias.c | 236 ++++++++++++++++++++++++++++++++
>  drivers/misc/storage-by-uuid.c  | 202 ---------------------------
>  fs/devfs-core.c                 | 104 ++++++++++----
>  include/block.h                 |   1 +
>  include/bootscan.h              |   5 +-
>  include/driver.h                |  20 +--
>  12 files changed, 440 insertions(+), 291 deletions(-)
>  create mode 100644 drivers/misc/storage-by-alias.c
>  delete mode 100644 drivers/misc/storage-by-uuid.c
> 
> -- 
> 2.39.5
> 
> 
>