From: Lars Schmidt <l.schmidt@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Lars Schmidt <lsc@pengutronix.de>
Subject: [PATCH] pinctrl: at91: add sama5d3 compatible after DT regression
Date: Wed, 16 Apr 2025 17:30:08 +0200 [thread overview]
Message-ID: <20250416153008.1898565-1-l.schmidt@pengutronix.de> (raw)
From: Lars Schmidt <lsc@pengutronix.de>
Commit f9abec74133a6 ("ARM: dts: microchip: Remove additional compatible
string from PIO3 pinctrl nodes") removed compatible string
atmel,at91sam9x5-pinctrl, which was used by pinctrl driver for sama3d3 in
barebox. Compatible string atmel,sama5d3-pinctrl was left in list, so
that needs to be included for identification.
The removal caused an issue during boot process. The system did still boot,
but no bootloader console was shown. Leaving the user without
possibility to interact with the bootloader.
The DT ABI breakage has been reported upstream:
https://lore.kernel.org/all/fcdb9283-07aa-4d50-ac4d-317b0a4e5f7e@pengutronix.de/
Signed-off-by: Lars Schmidt <lsc@pengutronix.de>
---
drivers/pinctrl/pinctrl-at91.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index a3372a5035..ddc725187b 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -370,6 +370,9 @@ static struct at91_pinctrl_mux_ops at91sam9x5_ops = {
static struct of_device_id at91_pinctrl_dt_ids[] = {
{
+ .compatible = "atmel,sama5d3-pinctrl",
+ .data = &at91sam9x5_ops,
+ }, {
.compatible = "atmel,at91rm9200-pinctrl",
.data = &at91rm9200_ops,
}, {
--
2.39.5
next reply other threads:[~2025-04-16 16:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 15:30 Lars Schmidt [this message]
2025-04-17 9:29 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416153008.1898565-1-l.schmidt@pengutronix.de \
--to=l.schmidt@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=lsc@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox