From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master 1/2] crypto: ecc: use HWRNG for random numbers
Date: Thu, 17 Apr 2025 08:21:51 +0200 [thread overview]
Message-ID: <20250417062152.3425911-1-a.fatoum@pengutronix.de> (raw)
The kernel's get_random_bytes provides random numbers suitable for crypto
purposes, while in barebox, we need to use get_crypto_bytes for that.
This footgun needs to be fixed, but until we do, let's make sure crypto
code doesn't use a badly seeded PRNG.
Fortunately crypto_ecdh_shared_secret is currently unused and this
doesn't affect any upstream users.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
crypto/ecc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/ecc.c b/crypto/ecc.c
index d91948bddbde..b90fe0e74809 100644
--- a/crypto/ecc.c
+++ b/crypto/ecc.c
@@ -1621,7 +1621,7 @@ int crypto_ecdh_shared_secret(unsigned int curve_id, unsigned int ndigits,
nbytes = ndigits << ECC_DIGITS_TO_BYTES_SHIFT;
- get_random_bytes(rand_z, nbytes);
+ get_crypto_bytes(rand_z, nbytes);
pk = ecc_alloc_point(ndigits);
if (!pk) {
--
2.39.5
next reply other threads:[~2025-04-17 6:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 6:21 Ahmad Fatoum [this message]
2025-04-17 6:21 ` [PATCH master 2/2] crypto: imx-scc: blobgen: " Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417062152.3425911-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox