From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 17 Apr 2025 08:24:15 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u5IfW-001lWZ-3C for lore@lore.pengutronix.de; Thu, 17 Apr 2025 08:24:15 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1u5IfW-0003h9-Ep for lore@pengutronix.de; Thu, 17 Apr 2025 08:24:14 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=4uh6L7cDotgFscdPesnruvl2jsieSVh1YFHZZt9FEkI=; b=ws66lHuIJlR6i3l1MNFvzBzD/t 1RuVF4FPM3NEDII6uu0E1dOh+AIvlMmZ5gTvGlPxp9w6SOhc46RtWDEk3zTLsjIO8yNWIjT1WoQdn /3A3fM95HJETMNX6Rq3lQMJv+8CSFxoVBeWctprWTC6JO4lRZaYR/1wU2NJMyTInsFQ0Ptlgdo3mX fFW+vNOBxlW6as3zdYIEioO7HUuIqxuxNk1v4tKpd5cZWofwzVDDNYJGavwXVzv0ilpShaNoC2bbO ksXzUD0ylIBUTfI1Jj6zhBozxykuOF9tnTnZrYuNLwuL+CZt7fuBsHJK15U5nKjXuaBP09vZu+eAJ I1uzKl3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u5Iet-0000000BtTa-47qs; Thu, 17 Apr 2025 06:23:35 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u5IdG-0000000BtJG-3u3L for barebox@lists.infradead.org; Thu, 17 Apr 2025 06:21:56 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1u5IdE-0002w2-Sj; Thu, 17 Apr 2025 08:21:52 +0200 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u5IdE-000hnf-2G; Thu, 17 Apr 2025 08:21:52 +0200 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1u5IdE-00ENIq-1x; Thu, 17 Apr 2025 08:21:52 +0200 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Thu, 17 Apr 2025 08:21:51 +0200 Message-Id: <20250417062152.3425911-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250416_232154_966137_9FFD18E9 X-CRM114-Status: GOOD ( 10.35 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH master 1/2] crypto: ecc: use HWRNG for random numbers X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) The kernel's get_random_bytes provides random numbers suitable for crypto purposes, while in barebox, we need to use get_crypto_bytes for that. This footgun needs to be fixed, but until we do, let's make sure crypto code doesn't use a badly seeded PRNG. Fortunately crypto_ecdh_shared_secret is currently unused and this doesn't affect any upstream users. Signed-off-by: Ahmad Fatoum --- crypto/ecc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/ecc.c b/crypto/ecc.c index d91948bddbde..b90fe0e74809 100644 --- a/crypto/ecc.c +++ b/crypto/ecc.c @@ -1621,7 +1621,7 @@ int crypto_ecdh_shared_secret(unsigned int curve_id, unsigned int ndigits, nbytes = ndigits << ECC_DIGITS_TO_BYTES_SHIFT; - get_random_bytes(rand_z, nbytes); + get_crypto_bytes(rand_z, nbytes); pk = ecc_alloc_point(ndigits); if (!pk) { -- 2.39.5