mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master] font: fbconsole: fix underflow when printing non-ASCII characters
Date: Tue, 22 Apr 2025 07:36:41 +0200	[thread overview]
Message-ID: <20250422053641.3435585-1-a.fatoum@pengutronix.de> (raw)

With signed characters, non-ASCII characters (i.e. valued >= 128)
are negative and remain so when casted to int.

find_font_index will thus multiply the index with a negative number and
look for font data before the actual start of the font.

A cast to unsigned fixes this, because all fonts that trigger this if
clause's branch have 256 characters.

Fixes: 27f79c05ab42 ("video: implement framebuffer console")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 lib/fonts/fonts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/fonts/fonts.c b/lib/fonts/fonts.c
index b3bdaa21a2aa..6047b4cbe223 100644
--- a/lib/fonts/fonts.c
+++ b/lib/fonts/fonts.c
@@ -37,7 +37,7 @@ int find_font_index(const struct font_desc *font, int ch)
 	if (font->index == NULL) {
 		index  = DIV_ROUND_UP(font->width, 8);
 		index *= font->height;
-		index *= ch;
+		index *= (unsigned char)ch;
 	} else {
 		/*
 		* FIXME: use binary search instead!
-- 
2.39.5




                 reply	other threads:[~2025-04-22  5:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250422053641.3435585-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox