mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/2] mfd: syscon: make mfd/syscon.h header self-contained
@ 2025-04-22  7:55 Ahmad Fatoum
  2025-04-22  7:55 ` [PATCH 2/2] dma: make " Ahmad Fatoum
  2025-04-22  9:23 ` [PATCH 1/2] mfd: syscon: make mfd/syscon.h " Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2025-04-22  7:55 UTC (permalink / raw)
  To: barebox

From: Ahmad Fatoum <a.fatoum@barebox.org>

Including the header in new files can currently break the build if
suitable headers aren't included beforehand.

Make it self-contained and while at it, switch over to SPDX.

Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
 include/mfd/syscon.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/include/mfd/syscon.h b/include/mfd/syscon.h
index f22d4e620b05..288dd464b7c6 100644
--- a/include/mfd/syscon.h
+++ b/include/mfd/syscon.h
@@ -1,20 +1,20 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/* SPDX-FileCopyrightText: (C) 2012 Freescale Semiconductor, Inc. */
+/* SPDX-FileCopyrightText: (C) (C) 2012 Linaro Ltd. */
 /* System Control Driver
  *
  * Based on linux driver by:
- *  Copyright (C) 2012 Freescale Semiconductor, Inc.
- *  Copyright (C) 2012 Linaro Ltd.
  *  Author: Dong Aisheng <dong.aisheng@linaro.org>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
  */
 
 #ifndef __MFD_SYSCON_H__
 #define __MFD_SYSCON_H__
 
+#include <linux/compiler.h>
+#include <linux/err.h>
+
 struct regmap;
+struct device_node;
 
 #ifdef CONFIG_MFD_SYSCON
 void __iomem *syscon_base_lookup_by_phandle
-- 
2.39.5




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] dma: make header self-contained
  2025-04-22  7:55 [PATCH 1/2] mfd: syscon: make mfd/syscon.h header self-contained Ahmad Fatoum
@ 2025-04-22  7:55 ` Ahmad Fatoum
  2025-04-22  9:23 ` [PATCH 1/2] mfd: syscon: make mfd/syscon.h " Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2025-04-22  7:55 UTC (permalink / raw)
  To: barebox

From: Ahmad Fatoum <a.fatoum@barebox.org>

There are barebox-specific types used in the file, which are defined
outside. Fix this.

Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
 include/dma-devices.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/dma-devices.h b/include/dma-devices.h
index dbc6759496e5..bbb25770f86b 100644
--- a/include/dma-devices.h
+++ b/include/dma-devices.h
@@ -2,6 +2,8 @@
 #ifndef __DMA_DEVICES_H
 #define __DMA_DEVICES_H
 
+#include <linux/types.h>
+
 /**
  * enum dma_transfer_direction - dma transfer mode and direction indicator
  * @DMA_MEM_TO_MEM: Async/Memcpy mode
-- 
2.39.5




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] mfd: syscon: make mfd/syscon.h header self-contained
  2025-04-22  7:55 [PATCH 1/2] mfd: syscon: make mfd/syscon.h header self-contained Ahmad Fatoum
  2025-04-22  7:55 ` [PATCH 2/2] dma: make " Ahmad Fatoum
@ 2025-04-22  9:23 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2025-04-22  9:23 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Tue, 22 Apr 2025 09:55:30 +0200, Ahmad Fatoum wrote:
> Including the header in new files can currently break the build if
> suitable headers aren't included beforehand.
> 
> Make it self-contained and while at it, switch over to SPDX.
> 
> 

Applied, thanks!

[1/2] mfd: syscon: make mfd/syscon.h header self-contained
      https://git.pengutronix.de/cgit/barebox/commit/?id=abe01ccf7d3d (link may not be stable)
[2/2] dma: make header self-contained
      https://git.pengutronix.de/cgit/barebox/commit/?id=b46c4abccdf6 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-04-22 10:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-22  7:55 [PATCH 1/2] mfd: syscon: make mfd/syscon.h header self-contained Ahmad Fatoum
2025-04-22  7:55 ` [PATCH 2/2] dma: make " Ahmad Fatoum
2025-04-22  9:23 ` [PATCH 1/2] mfd: syscon: make mfd/syscon.h " Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox