From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] fixup! mci: move mci_setup_cmd definition into header
Date: Wed, 23 Apr 2025 10:38:01 +0200 [thread overview]
Message-ID: <20250423083801.4137407-1-a.fatoum@pengutronix.de> (raw)
mci: dwcmshc-sdhci: fix redefinition of mci_setup_cmd
No defconfigs currently enable the driver, so it went unnoticed that it
already defines mci_setup_cmd and that this would clash with defining it
in a header.
The allyesconfig CI test noticed that though, so drop the now duplicate
definition.
We likely will want to enable this driver in the kvx defconfig though
going forward.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/mci/dwcmshc-sdhci.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/mci/dwcmshc-sdhci.c b/drivers/mci/dwcmshc-sdhci.c
index a7306fdb44a4..8398889a703c 100644
--- a/drivers/mci/dwcmshc-sdhci.c
+++ b/drivers/mci/dwcmshc-sdhci.c
@@ -40,14 +40,6 @@ static inline struct dwcmshc_host *priv_from_mci_host(struct mci_host *h)
return container_of(h, struct dwcmshc_host, mci);
}
-static void mci_setup_cmd(struct mci_cmd *p, unsigned int cmd, unsigned int arg,
- unsigned int response)
-{
- p->cmdidx = cmd;
- p->cmdarg = arg;
- p->resp_type = response;
-}
-
static int do_abort_sequence(struct mci_host *mci, struct mci_cmd *current_cmd)
{
int ret = 0;
--
2.39.5
next reply other threads:[~2025-04-23 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 8:38 Ahmad Fatoum [this message]
2025-04-23 9:50 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423083801.4137407-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox