From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 25 Apr 2025 07:51:02 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u8Bxm-0058TZ-0y for lore@lore.pengutronix.de; Fri, 25 Apr 2025 07:51:02 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1u8Bxl-0006Us-O3 for lore@pengutronix.de; Fri, 25 Apr 2025 07:51:02 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=uHFALbd7cGtq7jIjTdtWOZBSHlZLB8Cj/yS52bymQ9U=; b=qFpnu8hxufFw7EP04yriS//QnW JBA91EfIzljj7Hl/lXZLLxI75YbOvpK7PrCDTjQ92kq9LxBhdZIZsp/KwsI0r/maXcDfY6jDT8S6Y IAohPmiswz8PtpW3rzzCtDchLH1NjJ5zihvpXOuWiRDVCiXHXgGkllS7xQ0noXjfHlERnBWOwGaO6 PXY6ZOQuWxRecCwOV0DddSss0Xk0fXYMQBddh5VoMQItRDDQ/XUdh/SMJfBYAktApNwO0siq5g/zq arPr8tY7SAju5YmHEvNeIlRWJps7DM/eY3wCgvaBHd5EnzBfjaKcdV2gApeFvb7wDnp8AY/LH2xHF nKQggEuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u8BxF-0000000G14z-2zko; Fri, 25 Apr 2025 05:50:29 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u8BvZ-0000000G0wD-2wcy for barebox@lists.infradead.org; Fri, 25 Apr 2025 05:48:46 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1u8BvV-0006Bh-4y; Fri, 25 Apr 2025 07:48:41 +0200 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u8BvU-001zre-38; Fri, 25 Apr 2025 07:48:40 +0200 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1u8BvU-008dkR-2p; Fri, 25 Apr 2025 07:48:40 +0200 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Fri, 25 Apr 2025 07:48:39 +0200 Message-Id: <20250425054839.2059381-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250424_224845_736873_06AB9E14 X-CRM114-Status: GOOD ( 10.02 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH] fixup! commands: devlookup: add support for cdev aliases X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) commands: devlookup: fix memory leak in error case There's a string_list_free after out:, which we are skipping when we directly return. Signed-off-by: Ahmad Fatoum --- commands/devlookup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/commands/devlookup.c b/commands/devlookup.c index 5877d5f1b82c..b7fd7be3b624 100644 --- a/commands/devlookup.c +++ b/commands/devlookup.c @@ -59,7 +59,8 @@ static int do_devlookup(int argc, char *argv[]) aliasbuf = string_list_join(&sl, " "); if (string_list_count(&sl) > 1 && (kernelopt || paramname)) { printf("Option not supported for multi cdev alias\n"); - return COMMAND_ERROR; + ret = COMMAND_ERROR; + goto out; } if (alias) { -- 2.39.5