mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: johannes@gnu-linux.rocks
To: barebox@lists.infradead.org, s.hauer@pengutronix.de
Cc: Johannes Roith <johannes@gnu-linux.rocks>
Subject: [PATCH] zedboard correct comments in lowlevel.c
Date: Mon, 28 Apr 2025 19:54:24 +0200	[thread overview]
Message-ID: <20250428175424.9060-1-johannes@gnu-linux.rocks> (raw)

From: Johannes Roith <johannes@gnu-linux.rocks>

Signed-off-by: Johannes Roith <johannes@gnu-linux.rocks>

According to the TRM of the Zynq 7000 the registers under 'UART1 pinmux'
represents the pinmux for UART0. So, I fixed the comments and also
added the pin number for the UART0, UART1 and QSPI pins to the pinctrl.

Link to TRM page for pinmux:

https://docs.amd.com/r/en-US/ug585-zynq-7000-SoC-TRM/Register-slcr-MIO_PIN_50

---
 arch/arm/boards/avnet-zedboard/lowlevel.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boards/avnet-zedboard/lowlevel.c b/arch/arm/boards/avnet-zedboard/lowlevel.c
index 026a03d04b..605aab783a 100644
--- a/arch/arm/boards/avnet-zedboard/lowlevel.c
+++ b/arch/arm/boards/avnet-zedboard/lowlevel.c
@@ -223,12 +223,13 @@ static void avnet_zedboard_ps7_init(void)
 	writel(0x00000081, 0XF8006000);
 
 	/* poor mans pinctrl */
+	/* UART1 pinmux TxD: MIO_PIN 48, RxD: MIO_PIN 49 */
 	writel(0x000002E0, ZYNQ_MIO_BASE + 0xC0);
 	writel(0x000002E1, ZYNQ_MIO_BASE + 0xC4);
-	/* UART1 pinmux */
+	/* UART0 pinmux TxD: MIO_PIN 50, RxD: MIO_PIN 51 */
 	writel(0x000002E1, ZYNQ_MIO_BASE + 0xC8);
 	writel(0x000002E0, ZYNQ_MIO_BASE + 0xCC);
-	/* QSPI pinmux */
+	/* QSPI pinmux MIO_PIN 01 - 08 */
 	writel(0x00001602, ZYNQ_MIO_BASE + 0x04);
 	writel(0x00000702, ZYNQ_MIO_BASE + 0x08);
 	writel(0x00000702, ZYNQ_MIO_BASE + 0x0c);
-- 
2.39.5




                 reply	other threads:[~2025-04-28 17:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250428175424.9060-1-johannes@gnu-linux.rocks \
    --to=johannes@gnu-linux.rocks \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox