mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] barebox.h: correct barebox_main default comment
@ 2025-07-01 12:34 Bo Sun
  2025-07-02  6:15 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Bo Sun @ 2025-07-01 12:34 UTC (permalink / raw)
  To: barebox

The comment incorrectly states that barebox_main defaults to
run_shell() when a shell is enabled. In fact, it defaults to
run_init() when both shell and command support are enabled.
Update the comment to match the actual logic.

Signed-off-by: Bo Sun <bo@mboxify.com>
---
 include/barebox.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/barebox.h b/include/barebox.h
index 1b291129e9..6f3179d4bd 100644
--- a/include/barebox.h
+++ b/include/barebox.h
@@ -14,7 +14,7 @@ void __noreturn hang (void);
 
 /*
  * Function pointer to the main barebox function. Defaults
- * to run_shell() when a shell is enabled.
+ * to run_init() when shell and command support are enabled.
  */
 extern int (*barebox_main)(void);
 



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] barebox.h: correct barebox_main default comment
  2025-07-01 12:34 [PATCH] barebox.h: correct barebox_main default comment Bo Sun
@ 2025-07-02  6:15 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2025-07-02  6:15 UTC (permalink / raw)
  To: barebox, Bo Sun


On Tue, 01 Jul 2025 20:34:13 +0800, Bo Sun wrote:
> The comment incorrectly states that barebox_main defaults to
> run_shell() when a shell is enabled. In fact, it defaults to
> run_init() when both shell and command support are enabled.
> Update the comment to match the actual logic.
> 
> 

Applied, thanks!

[1/1] barebox.h: correct barebox_main default comment
      https://git.pengutronix.de/cgit/barebox/commit/?id=6a7348f3f1f6 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-02  7:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-01 12:34 [PATCH] barebox.h: correct barebox_main default comment Bo Sun
2025-07-02  6:15 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox