mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: [PATCH v1 1/4] video: simplefb-client: switch to dev_get_resource
Date: Tue, 29 Jul 2025 23:36:56 +0300	[thread overview]
Message-ID: <20250729203659.1858575-2-ivo.ivanov.ivanov1@gmail.com> (raw)
In-Reply-To: <20250729203659.1858575-1-ivo.ivanov.ivanov1@gmail.com>

Since the framebuffer memory resource resides in ram, it has already
been requested and mapped, so only get the resource to avoid
requesting a busy resource. This is also the approach for linux.

While at it, use IOMEM for mem->start and drop an unnecessary newline.

Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
---
 drivers/video/simplefb-client.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/video/simplefb-client.c b/drivers/video/simplefb-client.c
index dafec617..41ad8ffa 100644
--- a/drivers/video/simplefb-client.c
+++ b/drivers/video/simplefb-client.c
@@ -96,7 +96,7 @@ static int simplefb_probe(struct device *dev)
 	if (ret)
 		return ret;
 
-	mem = dev_request_mem_resource(dev, 0);
+	mem = dev_get_resource(dev, IORESOURCE_MEM, 0);
 	if (IS_ERR(mem)) {
 		dev_err(dev, "No memory resource\n");
 		return PTR_ERR(mem);
@@ -116,10 +116,9 @@ static int simplefb_probe(struct device *dev)
 	info->blue = params.format->blue;
 	info->transp = params.format->transp;
 
-	info->screen_base = (void *)mem->start;
+	info->screen_base = IOMEM(mem->start);
 	info->screen_size = resource_size(mem);
 
-
 	info->fbops = &simplefb_ops;
 
 	info->dev.parent = dev;
-- 
2.43.0




  reply	other threads:[~2025-07-29 20:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29 20:36 [PATCH v1 0/4] ARM: boards: add support for Samsung Galaxy S8 and S20 5G Ivaylo Ivanov
2025-07-29 20:36 ` Ivaylo Ivanov [this message]
2025-07-30  8:11   ` [PATCH v1 1/4] video: simplefb-client: switch to dev_get_resource Ahmad Fatoum
2025-07-30 11:28     ` Ivaylo Ivanov
2025-07-30 12:31       ` Ahmad Fatoum
2025-07-29 20:36 ` [PATCH v1 2/4] clocksource: arm_architected_timer: support clock-frequency Ivaylo Ivanov
2025-07-30  8:13   ` Ahmad Fatoum
2025-08-05  7:40   ` (subset) " Sascha Hauer
2025-07-29 20:36 ` [PATCH v1 3/4] ARM: boards: add support for Samsung Galaxy S8 (dreamlte) Ivaylo Ivanov
2025-07-30  8:31   ` Ahmad Fatoum
2025-07-30  9:09     ` Ivaylo Ivanov
2025-07-30  9:33       ` Ahmad Fatoum
2025-07-30 11:12         ` Ivaylo Ivanov
2025-07-29 20:36 ` [PATCH v1 4/4] ARM: boards: add support for Samsung Galaxy S20 5G (x1s) Ivaylo Ivanov
2025-07-30  8:48   ` Ahmad Fatoum
2025-07-30  9:16     ` Ivaylo Ivanov
2025-07-30  9:44       ` Ahmad Fatoum
2025-07-30 11:18         ` Ivaylo Ivanov
2025-07-30 12:50           ` Ahmad Fatoum
2025-07-30 13:12             ` Ivaylo Ivanov
2025-07-30 13:26               ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250729203659.1858575-2-ivo.ivanov.ivanov1@gmail.com \
    --to=ivo.ivanov.ivanov1@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox