From: Marco Felsch <m.felsch@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH] ARM: i.MX8M: remove early handoff-data handling
Date: Wed, 30 Jul 2025 19:02:52 +0200 [thread overview]
Message-ID: <20250730170252.1285892-1-m.felsch@pengutronix.de> (raw)
Commit fd1fbc15d5b9 ("ARM: i.MX: move handoff-data out of OCRAM") added
the support to store early handoff-data within DRAM. As the commit says
this says, this was to be prepared for early-board handoff data passing.
The commit added the support only for i.MX8MM and i.MX93. All other
i.MX8MQ/P/N platforms are left out. This isn't very intuitiv given that
the commit prepared the common code base for future usage.
Furthermore putting the handoff data infront of the bootloader caused a
regression on a custom i.MX8MM board which makes use of the
__imx8mm_load_and_start_image_via_tfa() because barebox is directly
loaded behind secure marked memory.
This partly reverts fd1fbc15d5b9 ("ARM: i.MX: move handoff-data out of
OCRAM") because the early board handoff-data is still unused after a
year and it aligns the common bootflow for i.MX8MQ/P/N/M again.
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
Hi,
I wasn't shure how to handle this regression, but in the end I went this
way. Of course I could adapt the lowlevel board code as well to honor
the handoff_data_size(). But I went this way, since this was implemented
for i.MX8MM SoCs only and there is actual no user of it.
That beeing said, IMHO the early board lowlevel handoff-data handling
should be done by the board lowlevel code because the location is very
board specific.
Regards,
Marco
arch/arm/mach-imx/atf.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/mach-imx/atf.c b/arch/arm/mach-imx/atf.c
index e6c21107a54a..11fe0334059d 100644
--- a/arch/arm/mach-imx/atf.c
+++ b/arch/arm/mach-imx/atf.c
@@ -112,8 +112,6 @@ void imx8mm_load_bl33(void *bl33)
hang();
}
- handoff_data_move(bl33 - ALIGN(handoff_data_size(), 0x1000));
-
/*
* On completion the TF-A will jump to MX8M_ATF_BL33_BASE_ADDR
* in EL2. Copy the image there, but replace the PBL part of
--
2.39.5
next reply other threads:[~2025-07-30 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 17:02 Marco Felsch [this message]
2025-08-05 5:16 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250730170252.1285892-1-m.felsch@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox