mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH] fixup! test: add support for pytest --graphic
Date: Wed,  6 Aug 2025 08:19:14 +0200	[thread overview]
Message-ID: <20250806061914.1697955-1-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20250708193600.758772-5-a.fatoum@barebox.org>

Supply qemu options only for qemu targets. Otherwise

labgrid-pytest --lg-env test/sandbox/sandbox_defconfig.yaml

fails with:

_pytest.outcomes.Exit: Qemu option supplied for non-Qemu targe

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 conftest.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/conftest.py b/conftest.py
index e3f09bac31..782ebc0536 100644
--- a/conftest.py
+++ b/conftest.py
@@ -125,7 +125,7 @@ def strategy(request, target, pytestconfig):
         else:
             pytest.exit("--graphics unsupported for target\n", 1)
 
-    strategy.append_qemu_args(graphics or '-nographic')
+        strategy.append_qemu_args(graphics)
 
     for i, blk in enumerate(pytestconfig.option.qemu_block):
         if virtio:
-- 
2.39.5




  reply	other threads:[~2025-08-06  6:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-08 19:35 [PATCH 0/4] test: add/document pytest --graphic, --env, --fs Ahmad Fatoum
2025-07-08 19:35 ` [PATCH 1/4] test: update requirement to Labgrid v25.0 Ahmad Fatoum
2025-07-08 19:35 ` [PATCH 2/4] test: drop now superfluous extra_args Ahmad Fatoum
2025-07-08 19:35 ` [PATCH 3/4] test: document pytest --env and --fs options Ahmad Fatoum
2025-07-08 19:36 ` [PATCH 4/4] test: add support for pytest --graphic Ahmad Fatoum
2025-08-06  6:19   ` Sascha Hauer [this message]
2025-08-06  6:20     ` [PATCH] fixup! " Sascha Hauer
2025-08-06  7:40     ` Ahmad Fatoum
2025-08-07  6:02   ` [PATCH 4/4] " Sascha Hauer
2025-08-05  9:26 ` [PATCH 0/4] test: add/document pytest --graphic, --env, --fs Sascha Hauer
2025-08-06 16:32 [PATCH] fixup! test: add support for pytest --graphic Ahmad Fatoum
2025-08-07  5:12 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250806061914.1697955-1-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox