mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] MAKEALL: query CONFIG_64BIT before make instead of CONFIG_ARM64 after
@ 2025-09-30  8:53 Ahmad Fatoum
  2025-09-30  9:54 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2025-09-30  8:53 UTC (permalink / raw)
  To: barebox; +Cc: sha, Ahmad Fatoum

The current logic inside MAKEALL is flawed: We source an ARM64 config
with CROSS_COMPILE=${CROSS_COMPILE_arm} and hope that CONFIG_ARM64
results, so we can grep for it in the .config despite it missing in the
defconfig.

Replace this by looking for CONFIG_64BIT instead in the defconfig
directly. This symbol seems to be there for all ARM64 configs we have
and if this ceases, CI will let us know.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 MAKEALL | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/MAKEALL b/MAKEALL
index d47f0204f1f1..abce297a9bf8 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -135,13 +135,10 @@ do_build_defconfig() {
 	[ -n "$logdir" ] && mkdir -p "${logdir}/${defconfig}"
 
 	MAKE="make -j${JOBS} ARCH=${arch} O=${BUILDDIR}"
-	${MAKE} ${defconfig} &>/dev/null
 
-	if [ ${arch} = "arm" ]; then
-		grep -q "CONFIG_ARM64=y" ${BUILDDIR}/.config
-		if [ $? = 0 ]; then
-			arch=arm64
-		fi
+	grep -q "CONFIG_64BIT=y" arch/${arch}/configs/${defconfig}
+	if [ $? = 0 ]; then
+		arch=arm64
 	fi
 
 	tmp=$(echo "${defconfig}" | tr - _)
-- 
2.47.3




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-09-30  9:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-30  8:53 [PATCH] MAKEALL: query CONFIG_64BIT before make instead of CONFIG_ARM64 after Ahmad Fatoum
2025-09-30  9:54 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox