From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 14 Oct 2025 11:39:06 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v8bUo-007gzX-1G for lore@lore.pengutronix.de; Tue, 14 Oct 2025 11:39:06 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v8bUn-0006hs-QO for lore@pengutronix.de; Tue, 14 Oct 2025 11:39:06 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=tNF1vEbjDEK9fhoJaCPaJ/zlqBlAuoH7tApOzWuzP0Y=; b=xdKWtZJeQBYwwsaFm/EGV7Aj3h WhzewvAtt0xZArbIXdIBFT0teHqoIdTuLCy/LBqRiUCDEZT+A8xMPLBrYfZ4aHZYGeKFDPvshSRSp uxljsagCspjAo656eym1jkP1ONiesI3WOScAPPWTV22s4l4d7N0yPpinx+FoitWxWlQ5igp2E8FAR Kyw82mzrfV653iImr7Vsk9/6CSdSRL7xiYcEo27PxcRSdYGKuF/BEwxi8majfloxmjpSMu6dZcuGN eo0xlyliv/GRsAIQAXBouiGVDOYJv3ng9dVQjajM7213Izor3cMlDELeOVFcasyfZ7MWImBYeTLP1 TkKKBMUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v8bUO-0000000Fmad-307a; Tue, 14 Oct 2025 09:38:40 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v8bUM-0000000FmaD-3maY for barebox@lists.infradead.org; Tue, 14 Oct 2025 09:38:39 +0000 Received: from dude04.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::ac]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1v8bUL-0006al-F6; Tue, 14 Oct 2025 11:38:37 +0200 From: Jonas Rebmann Date: Tue, 14 Oct 2025 11:38:36 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251014-ecdsa_keys-v1-1-08a72cfeec28@pengutronix.de> X-B4-Tracking: v=1; b=H4sIABsa7mgC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI1NDA0MT3dTklOLE+OzUymLdtBQLQyPTRAvjVGMLJaCGgqLUtMwKsGHRsbW 1ABbg6mxcAAAA X-Change-ID: 20251014-ecdsa_keys-fd8125a83e38 To: Sascha Hauer , BAREBOX Cc: Jonas Rebmann X-Mailer: b4 0.15-dev-7abec X-Developer-Signature: v=1; a=openpgp-sha256; l=2307; i=jre@pengutronix.de; h=from:subject:message-id; bh=6MXf+2JiNxdeYHMADL6W5EGj2hxVBxfKCjMW1yAx6Q0=; b=owGbwMvMwCV2ZcYT3onnbjcwnlZLYsh4JyVjcIbnkYHOp9izllwcHH91Ga5saLg0hSG/XyWoa MkO7uy8jlIWBjEuBlkxRZZYNTkFIWP/62aVdrEwc1iZQIYwcHEKwESmHmZkmNB51fOg5bx3vr3K ix1kZNfNrQ96YZMSuS3mGIv+87in8xgZjntHNvp9Slpw7lbno9CrwvwnXtSdPHuhZPpun9OGr+P k2AE= X-Developer-Key: i=jre@pengutronix.de; a=openpgp; fpr=0B7B750D5D3CD21B3B130DE8B61515E135CD49B5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251014_023838_940502_12056404 X-CRM114-Status: UNSURE ( 8.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH] crypto: ecdsa: remove unused ecdsa public key list X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) This code is unused in barebox and is misleading as we're using public_key lists containing keys of all supported types. Signed-off-by: Jonas Rebmann --- crypto/ecdsa.c | 18 ------------------ include/crypto/ecdsa.h | 7 ------- 2 files changed, 25 deletions(-) diff --git a/crypto/ecdsa.c b/crypto/ecdsa.c index 69c0accc95..6aaeff5c14 100644 --- a/crypto/ecdsa.c +++ b/crypto/ecdsa.c @@ -104,15 +104,6 @@ int ecdsa_verify(const struct ecdsa_public_key *key, const uint8_t *sig, return _ecdsa_verify(ctx, (void *)mhash, rh, sh); } -static LIST_HEAD(ecdsa_keys); - -int ecdsa_key_add(struct ecdsa_public_key *key) -{ - list_add_tail(&key->list, &ecdsa_keys); - - return 0; -} - struct ecdsa_public_key *ecdsa_key_dup(const struct ecdsa_public_key *key) { struct ecdsa_public_key *new; @@ -129,12 +120,3 @@ struct ecdsa_public_key *ecdsa_key_dup(const struct ecdsa_public_key *key) return new; } - -const struct ecdsa_public_key *ecdsa_key_next(const struct ecdsa_public_key *prev) -{ - prev = list_prepare_entry(prev, &ecdsa_keys, list); - list_for_each_entry_continue(prev, &ecdsa_keys, list) - return prev; - - return NULL; -} diff --git a/include/crypto/ecdsa.h b/include/crypto/ecdsa.h index 2e2b359d96..1bad70b9d2 100644 --- a/include/crypto/ecdsa.h +++ b/include/crypto/ecdsa.h @@ -4,21 +4,14 @@ #include #include -#include struct ecdsa_public_key { const char *curve_name; /* Name of curve, e.g. "prime256v1" */ const uint64_t *x; /* x coordinate of public key */ const uint64_t *y; /* y coordinate of public key */ unsigned int size_bits; /* key size in bits, derived from curve name */ - struct list_head list; }; -const struct ecdsa_public_key *ecdsa_key_next(const struct ecdsa_public_key *prev); - -#define for_each_ecdsa_key(key) \ - for (key = ecdsa_key_next(NULL); key; key = ecdsa_key_next(key)) - #ifdef CONFIG_CRYPTO_ECDSA int ecdsa_verify(const struct ecdsa_public_key *key, const uint8_t *sig, const uint32_t sig_len, const uint8_t *hash); --- base-commit: 8785a6ad7467b6f1f70b6e12aa2ceb2fdd5d8546 change-id: 20251014-ecdsa_keys-fd8125a83e38 Best regards, -- Jonas Rebmann