* [PATCH] virtio: Stop spamming debug buffer
@ 2025-10-14 9:37 Jonas Rebmann
2025-10-16 12:05 ` Ahmad Fatoum
2025-10-20 11:22 ` Sascha Hauer
0 siblings, 2 replies; 3+ messages in thread
From: Jonas Rebmann @ 2025-10-14 9:37 UTC (permalink / raw)
To: Sascha Hauer, BAREBOX; +Cc: Jonas Rebmann
At log level 7, this permanently prints over a hundred times per second,
probably unneeded debug print, drop it.
Signed-off-by: Jonas Rebmann <jre@pengutronix.de>
---
drivers/virtio/virtio_ring.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 284721aeff..c1c84e4961 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -241,10 +241,8 @@ void *virtqueue_get_buf(struct virtqueue *vq, unsigned int *len)
u16 last_used;
void *ret;
- if (!more_used(vq)) {
- vq_debug(vq, "No more buffers in queue\n");
+ if (!more_used(vq))
return NULL;
- }
/* Only get used array entries after they have been exposed by host */
virtio_rmb();
---
base-commit: 8785a6ad7467b6f1f70b6e12aa2ceb2fdd5d8546
change-id: 20251014-virtiospam-72c3f6fb134b
Best regards,
--
Jonas Rebmann <jre@pengutronix.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] virtio: Stop spamming debug buffer
2025-10-14 9:37 [PATCH] virtio: Stop spamming debug buffer Jonas Rebmann
@ 2025-10-16 12:05 ` Ahmad Fatoum
2025-10-20 11:22 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2025-10-16 12:05 UTC (permalink / raw)
To: Jonas Rebmann, Sascha Hauer, BAREBOX
On 10/14/25 11:37 AM, Jonas Rebmann wrote:
> At log level 7, this permanently prints over a hundred times per second,
> probably unneeded debug print, drop it.
>
> Signed-off-by: Jonas Rebmann <jre@pengutronix.de>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/virtio/virtio_ring.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 284721aeff..c1c84e4961 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -241,10 +241,8 @@ void *virtqueue_get_buf(struct virtqueue *vq, unsigned int *len)
> u16 last_used;
> void *ret;
>
> - if (!more_used(vq)) {
> - vq_debug(vq, "No more buffers in queue\n");
> + if (!more_used(vq))
> return NULL;
> - }
>
> /* Only get used array entries after they have been exposed by host */
> virtio_rmb();
>
> ---
> base-commit: 8785a6ad7467b6f1f70b6e12aa2ceb2fdd5d8546
> change-id: 20251014-virtiospam-72c3f6fb134b
>
> Best regards,
> --
> Jonas Rebmann <jre@pengutronix.de>
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] virtio: Stop spamming debug buffer
2025-10-14 9:37 [PATCH] virtio: Stop spamming debug buffer Jonas Rebmann
2025-10-16 12:05 ` Ahmad Fatoum
@ 2025-10-20 11:22 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2025-10-20 11:22 UTC (permalink / raw)
To: BAREBOX, Jonas Rebmann
On Tue, 14 Oct 2025 11:37:34 +0200, Jonas Rebmann wrote:
> At log level 7, this permanently prints over a hundred times per second,
> probably unneeded debug print, drop it.
>
>
Applied, thanks!
[1/1] virtio: Stop spamming debug buffer
https://git.pengutronix.de/cgit/barebox/commit/?id=d4131710d095 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-20 12:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-14 9:37 [PATCH] virtio: Stop spamming debug buffer Jonas Rebmann
2025-10-16 12:05 ` Ahmad Fatoum
2025-10-20 11:22 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox