mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Jonas Rebmann <jre@pengutronix.de>,
	Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master] security: hide CRYPTO_BUILTIN_DEVELOPMENT_KEYS behind INSECURE
Date: Wed, 15 Oct 2025 11:09:33 +0200	[thread overview]
Message-ID: <20251015090956.2298649-1-a.fatoum@pengutronix.de> (raw)

CONFIG_HAS_INSECURE_DEFAULTS is meant for options that may be insecure
by default and need extra care when used in secure deployments.

CONFIG_CRYPTO_BUILTIN_DEVELOPMENT_KEYS can't be used in a secure manner
at all and the help text spells it out, so it's more appropriate to have
it explicitly depending on INSECURE.

Cc: Jonas Rebmann <jre@pengutronix.de>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 security/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/security/Kconfig b/security/Kconfig
index 7ac92e4af760..40d468ae07d2 100644
--- a/security/Kconfig
+++ b/security/Kconfig
@@ -16,6 +16,7 @@ config INSECURE
 	  This option is a moving target. Currently it:
 
 	    - changes the default of global.env.autoprobe to 1
+	    - allows enablement of CRYPTO_BUILTIN_DEVELOPMENT_KEYS
 
 source "security/Kconfig.policy"
 
@@ -79,7 +80,7 @@ endchoice
 endif
 
 config CRYPTO_BUILTIN_DEVELOPMENT_KEYS
-	select HAS_INSECURE_DEFAULTS
+	depends on INSECURE
 	depends on CRYPTO_BUILTIN_KEYS
 	bool "Include development keys in build"
 	help
-- 
2.47.3




             reply	other threads:[~2025-10-15  9:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15  9:09 Ahmad Fatoum [this message]
2025-10-20 10:51 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251015090956.2298649-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=jre@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox