From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH] public-keys: fix warning message
Date: Fri, 21 Nov 2025 16:17:44 +0100 [thread overview]
Message-ID: <20251121151744.3481273-1-s.hauer@pengutronix.de> (raw)
idr_alloc() returns the id allocated or a negative error code. Checking
for an error with if (ret) is wrong, check for < 0 instead.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
crypto/public-keys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/public-keys.c b/crypto/public-keys.c
index 496970cc72..a2d31f4bc2 100644
--- a/crypto/public-keys.c
+++ b/crypto/public-keys.c
@@ -60,7 +60,7 @@ static int init_public_keys(void)
for (iter = __public_keys_start; iter != __public_keys_end; iter++) {
ret = idr_alloc(&public_keys, *iter, 0, INT_MAX, GFP_NOWAIT);
- if (ret)
+ if (ret < 0)
pr_warn("error while adding key\n");
}
--
2.47.3
reply other threads:[~2025-11-21 15:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251121151744.3481273-1-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox