From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH] console: return no pending character when console input forbidden
Date: Fri, 5 Dec 2025 15:28:32 +0100 [thread overview]
Message-ID: <20251205142832.1096749-1-s.hauer@pengutronix.de> (raw)
When console input is forbidden but was previously allowed then it can
happen that there are still characters left in the input fifo and
tstc() consequently returns 1. Code which then tries to read the pending
character will be stuck in getchar(). Fix this by returning 0 from
tstc() when console input is forbidden.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
common/console.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/common/console.c b/common/console.c
index 95e5fb4df3..fb75077812 100644
--- a/common/console.c
+++ b/common/console.c
@@ -568,6 +568,9 @@ EXPORT_SYMBOL(getchar);
int tstc(void)
{
+ if (!IS_ALLOWED(SCONFIG_CONSOLE_INPUT))
+ return 0;
+
return kfifo_len(console_input_fifo) || tstc_raw();
}
EXPORT_SYMBOL(tstc);
--
2.47.3
reply other threads:[~2025-12-05 14:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251205142832.1096749-1-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox