* [PATCH] console: return no pending character when console input forbidden
@ 2025-12-05 14:28 Sascha Hauer
0 siblings, 0 replies; only message in thread
From: Sascha Hauer @ 2025-12-05 14:28 UTC (permalink / raw)
To: Barebox List
When console input is forbidden but was previously allowed then it can
happen that there are still characters left in the input fifo and
tstc() consequently returns 1. Code which then tries to read the pending
character will be stuck in getchar(). Fix this by returning 0 from
tstc() when console input is forbidden.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
common/console.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/common/console.c b/common/console.c
index 95e5fb4df3..fb75077812 100644
--- a/common/console.c
+++ b/common/console.c
@@ -568,6 +568,9 @@ EXPORT_SYMBOL(getchar);
int tstc(void)
{
+ if (!IS_ALLOWED(SCONFIG_CONSOLE_INPUT))
+ return 0;
+
return kfifo_len(console_input_fifo) || tstc_raw();
}
EXPORT_SYMBOL(tstc);
--
2.47.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-12-05 14:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-05 14:28 [PATCH] console: return no pending character when console input forbidden Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox