From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 10 Dec 2025 11:16:43 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vTHFT-009sTA-1f for lore@lore.pengutronix.de; Wed, 10 Dec 2025 11:16:43 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vTHFS-0001uo-W4 for lore@pengutronix.de; Wed, 10 Dec 2025 11:16:43 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=st+z/YRTdfaWAaRhqCHTJZLLQSwCB15HtEelWgaDSFo=; b=MyGGphoGHth3xfZfRj5HFuRYDH HPThvq/umVIqfdv5SZdBt5t6xO6t0vSeHGSqBjwMuchGDoo9GBsvBEPZwsx8oLQZ8seTgmhiPOkWm Ja81GNTHiyAsMWbgP8gf5E+SmCMRw6pT/glFhQD2QpFUiBQmH7oF7z0sblfdRt1cMqbOjnztcuDFc LeuiADxxcQZvsq3UzBis+q//NnIUtXDQOGUyd1ORSxTIVsM2YewVGWFdwDsJ+tGR47dJKm3SU/xc/ He+U1eSRvv1rZnsa98Y9kG2tXttGWAyoZYgCpAz7aha4/yu8UgpEN2EiMPnwJGBg5M5R0EEapUYf/ QyHjOZBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vTHEw-0000000FJL1-2G2z; Wed, 10 Dec 2025 10:16:10 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vTHEq-0000000FJKD-0n8l for barebox@lists.infradead.org; Wed, 10 Dec 2025 10:16:08 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vTHEm-0001eJ-SK; Wed, 10 Dec 2025 11:16:00 +0100 Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vTHEm-004wMK-22; Wed, 10 Dec 2025 11:16:00 +0100 Received: from localhost ([::1] helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1vTHEm-00000004RFo-2IXJ; Wed, 10 Dec 2025 11:16:00 +0100 From: Sascha Hauer Date: Wed, 10 Dec 2025 11:15:59 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251210-devfs-prep-v1-1-3a2a3aa27eab@pengutronix.de> References: <20251210-devfs-prep-v1-0-3a2a3aa27eab@pengutronix.de> In-Reply-To: <20251210-devfs-prep-v1-0-3a2a3aa27eab@pengutronix.de> To: BAREBOX X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1765361760; l=867; i=s.hauer@pengutronix.de; s=20230412; h=from:subject:message-id; bh=cQKbrHLRlbqplYlI0igvXJjzfMQmf9MS5GCnKn2fjmY=; b=YIb7tpPL0ZDiKdymz6rO9aUS2O9OW7PZTHIfxbRtlfetH55Fj4U5ay0JxvJPqY85XzEAjnU0l CmSaN/ZtYwnAh5JlWS3iRSiPtYp3z8eMeboF1TFO/TVQMUSokvW+n9f X-Developer-Key: i=s.hauer@pengutronix.de; a=ed25519; pk=4kuc9ocmECiBJKWxYgqyhtZOHj5AWi7+d0n/UjhkwTg= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251210_021604_236580_B941312D X-CRM114-Status: UNSURE ( 9.24 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 1/3] fs: get path in path_init() X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Call path_get() in path_init() when dirfd doesn't belong to the current directory and is not the root directory. Without it path_put() will be called later without a previous path_get(). Reproducer: mkdir /ram mount -t ramfs none /ram stat -C ram . umount /ram Without this patch umount fails with -EBUSY. Signed-off-by: Sascha Hauer --- fs/fs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/fs.c b/fs/fs.c index d884726187dd526213f8b51a68a2e0db1bb50e58..f7859304a7b5f4158db83298b586c633668301d5 100644 --- a/fs/fs.c +++ b/fs/fs.c @@ -2251,6 +2251,7 @@ static const char *path_init(int dirfd, struct nameidata *nd, unsigned flags) nd->path.mnt = &f->fsdev->vfsmount; nd->path.dentry = f->f_path.dentry; + path_get(&nd->path); follow_mount(&nd->path); if (*s == '/') -- 2.47.3