From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] memory: fix dangling if in for_each_reserved_region
Date: Thu, 11 Dec 2025 21:42:16 +0100 [thread overview]
Message-ID: <20251211204217.2586463-1-a.fatoum@pengutronix.de> (raw)
This macro will cause issues if followed by an if else statement.
Invert the condition to fix this.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
include/memory.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/memory.h b/include/memory.h
index 65614b97ec8b..6a6f0e2eb7d3 100644
--- a/include/memory.h
+++ b/include/memory.h
@@ -28,7 +28,7 @@ int barebox_add_memory_bank(const char *name, resource_size_t start,
#define for_each_memory_bank(mem) list_for_each_entry(mem, &memory_banks, list)
#define for_each_reserved_region(mem, rsv) \
list_for_each_entry(rsv, &(mem)->res->children, sibling) \
- if (is_reserved_resource(rsv))
+ if (!is_reserved_resource(rsv)) {} else
#define for_each_memory_bank_region(bank, region) \
for_each_resource_region((bank)->res, region)
--
2.47.3
next reply other threads:[~2025-12-11 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 20:42 Ahmad Fatoum [this message]
2025-12-15 7:14 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251211204217.2586463-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox