[PATCH] memory: fix dangling if in for_each_reserved_region

[PATCH] memory: fix dangling if in for_each_reserved_region

[Ahmad Fatoum]

This macro will cause issues if followed by an if else statement.
Invert the condition to fix this.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 include/memory.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/memory.h b/include/memory.h
index 65614b97ec8b..6a6f0e2eb7d3 100644
--- a/include/memory.h
+++ b/include/memory.h
@@ -28,7 +28,7 @@ int barebox_add_memory_bank(const char *name, resource_size_t start,
 #define for_each_memory_bank(mem)	list_for_each_entry(mem, &memory_banks, list)
 #define for_each_reserved_region(mem, rsv) \
 	list_for_each_entry(rsv, &(mem)->res->children, sibling) \
-		if (is_reserved_resource(rsv))
+		if (!is_reserved_resource(rsv)) {} else
 
 #define for_each_memory_bank_region(bank, region) \
 	for_each_resource_region((bank)->res, region)
-- 
2.47.3

Re: [PATCH] memory: fix dangling if in for_each_reserved_region

[Sascha Hauer]

On Thu, 11 Dec 2025 21:42:16 +0100, Ahmad Fatoum wrote:
> This macro will cause issues if followed by an if else statement.
> Invert the condition to fix this.
> 
> 

Applied, thanks!

[1/1] memory: fix dangling if in for_each_reserved_region
      https://git.pengutronix.de/cgit/barebox/commit/?id=53cb008d16e6 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>