* [PATCH] memory: fix dangling if in for_each_reserved_region
@ 2025-12-11 20:42 Ahmad Fatoum
2025-12-15 7:14 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2025-12-11 20:42 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
This macro will cause issues if followed by an if else statement.
Invert the condition to fix this.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
include/memory.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/memory.h b/include/memory.h
index 65614b97ec8b..6a6f0e2eb7d3 100644
--- a/include/memory.h
+++ b/include/memory.h
@@ -28,7 +28,7 @@ int barebox_add_memory_bank(const char *name, resource_size_t start,
#define for_each_memory_bank(mem) list_for_each_entry(mem, &memory_banks, list)
#define for_each_reserved_region(mem, rsv) \
list_for_each_entry(rsv, &(mem)->res->children, sibling) \
- if (is_reserved_resource(rsv))
+ if (!is_reserved_resource(rsv)) {} else
#define for_each_memory_bank_region(bank, region) \
for_each_resource_region((bank)->res, region)
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-15 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-11 20:42 [PATCH] memory: fix dangling if in for_each_reserved_region Ahmad Fatoum
2025-12-15 7:14 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox