From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH v3 2/3] startup: bump down log message about lack of persistent environment
Date: Fri, 12 Dec 2025 17:22:08 +0100 [thread overview]
Message-ID: <20251212162222.1937214-3-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20251212162222.1937214-1-a.fatoum@pengutronix.de>
Not having a persisted environment is expected behavior in some configurations,
so emit it at info log level.
While at it, reword in preparation for the follow-up commit.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v2 -> v3:
- no change
---
common/startup.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/common/startup.c b/common/startup.c
index 53003b88bc1b..b6f8a49bb94b 100644
--- a/common/startup.c
+++ b/common/startup.c
@@ -99,12 +99,10 @@ static int load_environment(void)
ERR_PTR(ret));
}
- if (IS_ENABLED(CONFIG_ENV_HANDLING)) {
+ if (IS_ENABLED(CONFIG_ENV_HANDLING))
envfs_load(default_environment_path, "/env", 0);
- } else {
- if (IS_ENABLED(CONFIG_DEFAULT_ENVIRONMENT))
- pr_notice("No support for persistent environment. Using default environment\n");
- }
+ else if (IS_ENABLED(CONFIG_DEFAULT_ENVIRONMENT))
+ pr_info("external environment support disabled. Using default environment\n");
nvvar_load();
--
2.47.3
next prev parent reply other threads:[~2025-12-12 16:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 16:22 [PATCH v3 0/3] environment: allow board code to suppress external env loading Ahmad Fatoum
2025-12-12 16:22 ` [PATCH v3 1/3] globalvar: suppress nvvar_save when no external environment was loaded Ahmad Fatoum
2025-12-12 16:22 ` Ahmad Fatoum [this message]
2025-12-12 16:22 ` [PATCH v3 3/3] environment: allow board code to suppress external env loading Ahmad Fatoum
2025-12-15 8:33 ` [PATCH v3 0/3] " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251212162222.1937214-3-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox