From: Marco Felsch <m.felsch@pengutronix.de>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
imx@lists.linux.dev, Fabio Estevam <festevam@gmail.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-kernel@vger.kernel.org, frieder.schrempf@kontron.de,
oualid.derouiche@kontron.de, linux-renesas-soc@vger.kernel.org,
eberhard.stoll@kontron.de,
Pengutronix Kernel Team <kernel@pengutronix.de>,
barebox@lists.infradead.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
annette.kobou@kontron.de, Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: nxp/imx6: Drop unused .dtsi
Date: Sun, 14 Dec 2025 19:57:50 +0100 [thread overview]
Message-ID: <20251214185750.tzt6jf4zg5gtex63@pengutronix.de> (raw)
In-Reply-To: <CAL_JsqK9OREenZjBHrDh7AqsyUXYOzTOhY4e0qHGzYkX8tacWQ@mail.gmail.com>
On 25-12-14, Rob Herring wrote:
> On Sat, Dec 13, 2025 at 12:13 PM Marco Felsch <m.felsch@pengutronix.de> wrote:
> >
> > Hi Rob,
> >
> > On 25-12-12, Rob Herring (Arm) wrote:
> > > These .dtsi files are not included anywhere in the tree and can't be
> > > tested.
> >
> > not in the tree but by other projects, please see below.
> >
> > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > > ---
> > > .../dts/nxp/imx/imx6dl-kontron-samx6i.dtsi | 12 -----
> > > .../dts/nxp/imx/imx6q-kontron-samx6i.dtsi | 12 -----
> > > .../boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi | 45 ----------------
> > > .../boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi | 54 -------------------
> > > 4 files changed, 123 deletions(-)
> > > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi
> > > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi
> > > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi
> > > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi
> > >
> > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi
> > > deleted file mode 100644
> > > index 5a9b819d7ee8..000000000000
> > > --- a/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi
> > > +++ /dev/null
> > > @@ -1,12 +0,0 @@
> > > -// SPDX-License-Identifier: GPL-2.0 OR X11
> > > -/*
> > > - * Copyright 2019 (C) Pengutronix, Marco Felsch <kernel@pengutronix.de>
> > > - */
> > > -
> > > -#include "imx6dl.dtsi"
> > > -#include "imx6qdl-kontron-samx6i.dtsi"
> > > -
> > > -/ {
> > > - model = "Kontron SMARC-sAMX6i Dual-Lite/Solo";
> > > - compatible = "kontron,imx6dl-samx6i", "fsl,imx6dl";
> > > -};
> > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi
> > > deleted file mode 100644
> > > index e76963436079..000000000000
> > > --- a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi
> > > +++ /dev/null
> > > @@ -1,12 +0,0 @@
> > > -// SPDX-License-Identifier: GPL-2.0 OR X11
> > > -/*
> > > - * Copyright 2019 (C) Pengutronix, Marco Felsch <kernel@pengutronix.de>
> > > - */
> > > -
> > > -#include "imx6q.dtsi"
> > > -#include "imx6qdl-kontron-samx6i.dtsi"
> > > -
> > > -/ {
> > > - model = "Kontron SMARC-sAMX6i Quad/Dual";
> > > - compatible = "kontron,imx6q-samx6i", "fsl,imx6q";
> > > -};
> >
> > I can't speak for the other two .dtsi files but both kontron .dtsi files
> > are used by barebox:
> >
> > - https://elixir.bootlin.com/barebox/v2025.11.0/source/arch/arm/dts/imx6dl-samx6i.dts#L8
> > - https://elixir.bootlin.com/barebox/v2025.11.0/source/arch/arm/dts/imx6q-samx6i.dts#L8
> >
> > Removing them here will cause a regression for barebox.
>
> Please upstream something that uses the .dtsi. Other than the
> undocumented barebox property, no reason these can't be.
My intention wasn't to point to the barebox-only
"barebox,disable-deep-probe" property. I was refering to the include
line.
The two .dtsi files we're talking about are SoM .dtsi files. We don't
have access to the Kontron EVK baseboard which uses this SoM.
I've added a few Kontron devs which may can add the missing baseboard
support.
+Cc: frieder.schrempf@kontron.de
+Cc: annette.kobou@kontron.de
+Cc: oualid.derouiche@kontron.de
+Cc: eberhard.stoll@kontron.de
I could also add the imx6dl-samx6i.dts and imx6q-samx6i.dts like we do
in barebox. But as said, this would be a devicetree for a SoM which
makes sense for the bootloader but not for the kernel.
Regards,
Marco
>
> Rob
>
--
#gernperDu
#CallMeByMyFirstName
Pengutronix e.K. | |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
next prev parent reply other threads:[~2025-12-14 18:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251212203226.458694-5-robh@kernel.org>
2025-12-13 18:13 ` Marco Felsch
2025-12-14 14:41 ` Rob Herring
2025-12-14 18:57 ` Marco Felsch [this message]
2025-12-15 19:43 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251214185750.tzt6jf4zg5gtex63@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=annette.kobou@kontron.de \
--cc=barebox@lists.infradead.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eberhard.stoll@kontron.de \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=geert+renesas@glider.be \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=oualid.derouiche@kontron.de \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox