* Re: [PATCH] ARM: dts: nxp/imx6: Drop unused .dtsi [not found] <20251212203226.458694-5-robh@kernel.org> @ 2025-12-13 18:13 ` Marco Felsch 2025-12-14 14:41 ` Rob Herring 0 siblings, 1 reply; 4+ messages in thread From: Marco Felsch @ 2025-12-13 18:13 UTC (permalink / raw) To: Rob Herring (Arm) Cc: devicetree, Conor Dooley, Geert Uytterhoeven, imx, Fabio Estevam, Magnus Damm, linux-kernel, linux-renesas-soc, Pengutronix Kernel Team, barebox, Krzysztof Kozlowski, Shawn Guo, linux-arm-kernel Hi Rob, On 25-12-12, Rob Herring (Arm) wrote: > These .dtsi files are not included anywhere in the tree and can't be > tested. not in the tree but by other projects, please see below. > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > .../dts/nxp/imx/imx6dl-kontron-samx6i.dtsi | 12 ----- > .../dts/nxp/imx/imx6q-kontron-samx6i.dtsi | 12 ----- > .../boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi | 45 ---------------- > .../boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi | 54 ------------------- > 4 files changed, 123 deletions(-) > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi > deleted file mode 100644 > index 5a9b819d7ee8..000000000000 > --- a/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi > +++ /dev/null > @@ -1,12 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0 OR X11 > -/* > - * Copyright 2019 (C) Pengutronix, Marco Felsch <kernel@pengutronix.de> > - */ > - > -#include "imx6dl.dtsi" > -#include "imx6qdl-kontron-samx6i.dtsi" > - > -/ { > - model = "Kontron SMARC-sAMX6i Dual-Lite/Solo"; > - compatible = "kontron,imx6dl-samx6i", "fsl,imx6dl"; > -}; > diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi > deleted file mode 100644 > index e76963436079..000000000000 > --- a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi > +++ /dev/null > @@ -1,12 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0 OR X11 > -/* > - * Copyright 2019 (C) Pengutronix, Marco Felsch <kernel@pengutronix.de> > - */ > - > -#include "imx6q.dtsi" > -#include "imx6qdl-kontron-samx6i.dtsi" > - > -/ { > - model = "Kontron SMARC-sAMX6i Quad/Dual"; > - compatible = "kontron,imx6q-samx6i", "fsl,imx6q"; > -}; I can't speak for the other two .dtsi files but both kontron .dtsi files are used by barebox: - https://elixir.bootlin.com/barebox/v2025.11.0/source/arch/arm/dts/imx6dl-samx6i.dts#L8 - https://elixir.bootlin.com/barebox/v2025.11.0/source/arch/arm/dts/imx6q-samx6i.dts#L8 Removing them here will cause a regression for barebox. Regards, Marco > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi > deleted file mode 100644 > index 3a968782e854..000000000000 > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi > +++ /dev/null > @@ -1,45 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0+ OR MIT > -// > -// Copyright 2017 NXP > - > -#include "imx6qdl-pico.dtsi" > - > -/ { > - leds { > - compatible = "gpio-leds"; > - pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_gpio_leds>; > - > - led { > - label = "gpio-led"; > - gpios = <&gpio5 31 GPIO_ACTIVE_HIGH>; > - }; > - }; > - > -}; > - > -&i2c1 { > - mpl3115@60 { > - compatible = "fsl,mpl3115"; > - reg = <0x60>; > - }; > -}; > - > -&i2c2 { > - io-expander@25 { > - compatible = "nxp,pca9554"; > - reg = <0x25>; > - gpio-controller; > - #gpio-cells = <2>; > - #interrupt-cells = <2>; > - }; > - > -}; > - > -&iomuxc { > - pinctrl_gpio_leds: gpioledsgrp { > - fsl,pins = < > - MX6QDL_PAD_CSI0_DAT13__GPIO5_IO31 0x1b0b0 > - >; > - }; > -}; > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi > deleted file mode 100644 > index 3d56a4216448..000000000000 > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi > +++ /dev/null > @@ -1,54 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0+ OR MIT > - > -#include "imx6qdl-pico.dtsi" > - > -/ { > - leds { > - compatible = "gpio-leds"; > - pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_gpio_leds>; > - > - led { > - label = "gpio-led"; > - gpios = <&gpio5 31 GPIO_ACTIVE_HIGH>; > - }; > - }; > - > -}; > - > -&i2c1 { > - adc@52 { > - compatible = "ti,adc081c"; > - reg = <0x52>; > - vref-supply = <®_2p5v>; > - }; > -}; > - > -&i2c2 { > - io-expander@25 { > - compatible = "nxp,pca9554"; > - reg = <0x25>; > - gpio-controller; > - #gpio-cells = <2>; > - #interrupt-cells = <2>; > - }; > -}; > - > -&i2c3 { > - rtc@68 { > - compatible = "dallas,ds1337"; > - reg = <0x68>; > - }; > -}; > - > -&pcie { > - status = "okay"; > -}; > - > -&iomuxc { > - pinctrl_gpio_leds: gpioledsgrp { > - fsl,pins = < > - MX6QDL_PAD_CSI0_DAT13__GPIO5_IO31 0x1b0b0 > - >; > - }; > -}; > -- > 2.51.0 > > > -- #gernperDu #CallMeByMyFirstName Pengutronix e.K. | | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: nxp/imx6: Drop unused .dtsi 2025-12-13 18:13 ` [PATCH] ARM: dts: nxp/imx6: Drop unused .dtsi Marco Felsch @ 2025-12-14 14:41 ` Rob Herring 2025-12-14 18:57 ` Marco Felsch 0 siblings, 1 reply; 4+ messages in thread From: Rob Herring @ 2025-12-14 14:41 UTC (permalink / raw) To: Marco Felsch Cc: devicetree, Conor Dooley, Geert Uytterhoeven, imx, Fabio Estevam, Magnus Damm, linux-kernel, linux-renesas-soc, Pengutronix Kernel Team, barebox, Krzysztof Kozlowski, Shawn Guo, linux-arm-kernel On Sat, Dec 13, 2025 at 12:13 PM Marco Felsch <m.felsch@pengutronix.de> wrote: > > Hi Rob, > > On 25-12-12, Rob Herring (Arm) wrote: > > These .dtsi files are not included anywhere in the tree and can't be > > tested. > > not in the tree but by other projects, please see below. > > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > > --- > > .../dts/nxp/imx/imx6dl-kontron-samx6i.dtsi | 12 ----- > > .../dts/nxp/imx/imx6q-kontron-samx6i.dtsi | 12 ----- > > .../boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi | 45 ---------------- > > .../boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi | 54 ------------------- > > 4 files changed, 123 deletions(-) > > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi > > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi > > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi > > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi > > > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi > > deleted file mode 100644 > > index 5a9b819d7ee8..000000000000 > > --- a/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi > > +++ /dev/null > > @@ -1,12 +0,0 @@ > > -// SPDX-License-Identifier: GPL-2.0 OR X11 > > -/* > > - * Copyright 2019 (C) Pengutronix, Marco Felsch <kernel@pengutronix.de> > > - */ > > - > > -#include "imx6dl.dtsi" > > -#include "imx6qdl-kontron-samx6i.dtsi" > > - > > -/ { > > - model = "Kontron SMARC-sAMX6i Dual-Lite/Solo"; > > - compatible = "kontron,imx6dl-samx6i", "fsl,imx6dl"; > > -}; > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi > > deleted file mode 100644 > > index e76963436079..000000000000 > > --- a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi > > +++ /dev/null > > @@ -1,12 +0,0 @@ > > -// SPDX-License-Identifier: GPL-2.0 OR X11 > > -/* > > - * Copyright 2019 (C) Pengutronix, Marco Felsch <kernel@pengutronix.de> > > - */ > > - > > -#include "imx6q.dtsi" > > -#include "imx6qdl-kontron-samx6i.dtsi" > > - > > -/ { > > - model = "Kontron SMARC-sAMX6i Quad/Dual"; > > - compatible = "kontron,imx6q-samx6i", "fsl,imx6q"; > > -}; > > I can't speak for the other two .dtsi files but both kontron .dtsi files > are used by barebox: > > - https://elixir.bootlin.com/barebox/v2025.11.0/source/arch/arm/dts/imx6dl-samx6i.dts#L8 > - https://elixir.bootlin.com/barebox/v2025.11.0/source/arch/arm/dts/imx6q-samx6i.dts#L8 > > Removing them here will cause a regression for barebox. Please upstream something that uses the .dtsi. Other than the undocumented barebox property, no reason these can't be. Rob ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: nxp/imx6: Drop unused .dtsi 2025-12-14 14:41 ` Rob Herring @ 2025-12-14 18:57 ` Marco Felsch 2025-12-15 19:43 ` Rob Herring 0 siblings, 1 reply; 4+ messages in thread From: Marco Felsch @ 2025-12-14 18:57 UTC (permalink / raw) To: Rob Herring Cc: devicetree, Conor Dooley, Geert Uytterhoeven, imx, Fabio Estevam, Magnus Damm, linux-kernel, frieder.schrempf, oualid.derouiche, linux-renesas-soc, eberhard.stoll, Pengutronix Kernel Team, barebox, Krzysztof Kozlowski, annette.kobou, Shawn Guo, linux-arm-kernel On 25-12-14, Rob Herring wrote: > On Sat, Dec 13, 2025 at 12:13 PM Marco Felsch <m.felsch@pengutronix.de> wrote: > > > > Hi Rob, > > > > On 25-12-12, Rob Herring (Arm) wrote: > > > These .dtsi files are not included anywhere in the tree and can't be > > > tested. > > > > not in the tree but by other projects, please see below. > > > > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > > > --- > > > .../dts/nxp/imx/imx6dl-kontron-samx6i.dtsi | 12 ----- > > > .../dts/nxp/imx/imx6q-kontron-samx6i.dtsi | 12 ----- > > > .../boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi | 45 ---------------- > > > .../boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi | 54 ------------------- > > > 4 files changed, 123 deletions(-) > > > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi > > > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi > > > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi > > > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi > > > > > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi > > > deleted file mode 100644 > > > index 5a9b819d7ee8..000000000000 > > > --- a/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi > > > +++ /dev/null > > > @@ -1,12 +0,0 @@ > > > -// SPDX-License-Identifier: GPL-2.0 OR X11 > > > -/* > > > - * Copyright 2019 (C) Pengutronix, Marco Felsch <kernel@pengutronix.de> > > > - */ > > > - > > > -#include "imx6dl.dtsi" > > > -#include "imx6qdl-kontron-samx6i.dtsi" > > > - > > > -/ { > > > - model = "Kontron SMARC-sAMX6i Dual-Lite/Solo"; > > > - compatible = "kontron,imx6dl-samx6i", "fsl,imx6dl"; > > > -}; > > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi > > > deleted file mode 100644 > > > index e76963436079..000000000000 > > > --- a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi > > > +++ /dev/null > > > @@ -1,12 +0,0 @@ > > > -// SPDX-License-Identifier: GPL-2.0 OR X11 > > > -/* > > > - * Copyright 2019 (C) Pengutronix, Marco Felsch <kernel@pengutronix.de> > > > - */ > > > - > > > -#include "imx6q.dtsi" > > > -#include "imx6qdl-kontron-samx6i.dtsi" > > > - > > > -/ { > > > - model = "Kontron SMARC-sAMX6i Quad/Dual"; > > > - compatible = "kontron,imx6q-samx6i", "fsl,imx6q"; > > > -}; > > > > I can't speak for the other two .dtsi files but both kontron .dtsi files > > are used by barebox: > > > > - https://elixir.bootlin.com/barebox/v2025.11.0/source/arch/arm/dts/imx6dl-samx6i.dts#L8 > > - https://elixir.bootlin.com/barebox/v2025.11.0/source/arch/arm/dts/imx6q-samx6i.dts#L8 > > > > Removing them here will cause a regression for barebox. > > Please upstream something that uses the .dtsi. Other than the > undocumented barebox property, no reason these can't be. My intention wasn't to point to the barebox-only "barebox,disable-deep-probe" property. I was refering to the include line. The two .dtsi files we're talking about are SoM .dtsi files. We don't have access to the Kontron EVK baseboard which uses this SoM. I've added a few Kontron devs which may can add the missing baseboard support. +Cc: frieder.schrempf@kontron.de +Cc: annette.kobou@kontron.de +Cc: oualid.derouiche@kontron.de +Cc: eberhard.stoll@kontron.de I could also add the imx6dl-samx6i.dts and imx6q-samx6i.dts like we do in barebox. But as said, this would be a devicetree for a SoM which makes sense for the bootloader but not for the kernel. Regards, Marco > > Rob > -- #gernperDu #CallMeByMyFirstName Pengutronix e.K. | | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: nxp/imx6: Drop unused .dtsi 2025-12-14 18:57 ` Marco Felsch @ 2025-12-15 19:43 ` Rob Herring 0 siblings, 0 replies; 4+ messages in thread From: Rob Herring @ 2025-12-15 19:43 UTC (permalink / raw) To: Marco Felsch Cc: devicetree, Conor Dooley, Geert Uytterhoeven, imx, Fabio Estevam, Magnus Damm, linux-kernel, frieder.schrempf, oualid.derouiche, linux-renesas-soc, eberhard.stoll, Pengutronix Kernel Team, barebox, Krzysztof Kozlowski, annette.kobou, Shawn Guo, linux-arm-kernel On Sun, Dec 14, 2025 at 12:58 PM Marco Felsch <m.felsch@pengutronix.de> wrote: > > On 25-12-14, Rob Herring wrote: > > On Sat, Dec 13, 2025 at 12:13 PM Marco Felsch <m.felsch@pengutronix.de> wrote: > > > > > > Hi Rob, > > > > > > On 25-12-12, Rob Herring (Arm) wrote: > > > > These .dtsi files are not included anywhere in the tree and can't be > > > > tested. > > > > > > not in the tree but by other projects, please see below. > > > > > > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > > > > --- > > > > .../dts/nxp/imx/imx6dl-kontron-samx6i.dtsi | 12 ----- > > > > .../dts/nxp/imx/imx6q-kontron-samx6i.dtsi | 12 ----- > > > > .../boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi | 45 ---------------- > > > > .../boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi | 54 ------------------- > > > > 4 files changed, 123 deletions(-) > > > > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi > > > > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi > > > > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi > > > > delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi > > > > > > > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi > > > > deleted file mode 100644 > > > > index 5a9b819d7ee8..000000000000 > > > > --- a/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi > > > > +++ /dev/null > > > > @@ -1,12 +0,0 @@ > > > > -// SPDX-License-Identifier: GPL-2.0 OR X11 > > > > -/* > > > > - * Copyright 2019 (C) Pengutronix, Marco Felsch <kernel@pengutronix.de> > > > > - */ > > > > - > > > > -#include "imx6dl.dtsi" > > > > -#include "imx6qdl-kontron-samx6i.dtsi" > > > > - > > > > -/ { > > > > - model = "Kontron SMARC-sAMX6i Dual-Lite/Solo"; > > > > - compatible = "kontron,imx6dl-samx6i", "fsl,imx6dl"; > > > > -}; > > > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi > > > > deleted file mode 100644 > > > > index e76963436079..000000000000 > > > > --- a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi > > > > +++ /dev/null > > > > @@ -1,12 +0,0 @@ > > > > -// SPDX-License-Identifier: GPL-2.0 OR X11 > > > > -/* > > > > - * Copyright 2019 (C) Pengutronix, Marco Felsch <kernel@pengutronix.de> > > > > - */ > > > > - > > > > -#include "imx6q.dtsi" > > > > -#include "imx6qdl-kontron-samx6i.dtsi" > > > > - > > > > -/ { > > > > - model = "Kontron SMARC-sAMX6i Quad/Dual"; > > > > - compatible = "kontron,imx6q-samx6i", "fsl,imx6q"; > > > > -}; > > > > > > I can't speak for the other two .dtsi files but both kontron .dtsi files > > > are used by barebox: > > > > > > - https://elixir.bootlin.com/barebox/v2025.11.0/source/arch/arm/dts/imx6dl-samx6i.dts#L8 > > > - https://elixir.bootlin.com/barebox/v2025.11.0/source/arch/arm/dts/imx6q-samx6i.dts#L8 > > > > > > Removing them here will cause a regression for barebox. > > > > Please upstream something that uses the .dtsi. Other than the > > undocumented barebox property, no reason these can't be. > > My intention wasn't to point to the barebox-only > "barebox,disable-deep-probe" property. I was refering to the include > line. > > The two .dtsi files we're talking about are SoM .dtsi files. We don't > have access to the Kontron EVK baseboard which uses this SoM. > > I've added a few Kontron devs which may can add the missing baseboard > support. > > +Cc: frieder.schrempf@kontron.de > +Cc: annette.kobou@kontron.de > +Cc: oualid.derouiche@kontron.de > +Cc: eberhard.stoll@kontron.de > > I could also add the imx6dl-samx6i.dts and imx6q-samx6i.dts like we do > in barebox. But as said, this would be a devicetree for a SoM which > makes sense for the bootloader but not for the kernel. Why not? People use the kernel as a bootloader. There's also some discussions about splitting SoMs and baseboards into overlays for baseboards (and also even into SoC base DT plus overlay for boards). Rob ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-12-15 19:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20251212203226.458694-5-robh@kernel.org>
2025-12-13 18:13 ` [PATCH] ARM: dts: nxp/imx6: Drop unused .dtsi Marco Felsch
2025-12-14 14:41 ` Rob Herring
2025-12-14 18:57 ` Marco Felsch
2025-12-15 19:43 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox