From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 19 Dec 2025 11:37:55 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vWXrv-00DAZY-1N for lore@lore.pengutronix.de; Fri, 19 Dec 2025 11:37:55 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vWXrj-0005g1-MZ for lore@pengutronix.de; Fri, 19 Dec 2025 11:37:55 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V8GAvPeSa2nvnZF0ODxFCivvDza7oADXvJFq2/YZ4JY=; b=MA/GTXejaSQxBubmPKYYiBPKgU pQnNRnAGE5Kc6+GvGZxsjMUpTo/J/ybgrLcho0uVd7dFFEgVIE5XOsVV2R4oQvGde/Pv1ghe76bdJ uXfOlrOFk3U5wKc9Yk9R+SGAN7bHLyMPi+DFbnPUJ23ZLz2+mtma2NqMsiSLDhP5JdlLVb+1o6wb+ m5olHZA0JmPXfBEfnX5YC/AyfJN9MEKWTBsTZhWVZo1A+MSkaa6QIL580NhyhaQ7OvopTYRB7Sr1r zRR/I1BKTQDnwQbvaGthuNFSEA3FeB5Iw0YF9G9JDxOVZ0oSqDZ7593EbU411V0DEToDoYAHPjN6i Z3kMYVgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vWXqw-0000000A623-35zJ; Fri, 19 Dec 2025 10:36:54 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vWXqr-0000000A5uf-1Y4e for barebox@lists.infradead.org; Fri, 19 Dec 2025 10:36:51 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vWXqp-0004ZP-TL; Fri, 19 Dec 2025 11:36:47 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vWXqp-006RUA-2G; Fri, 19 Dec 2025 11:36:47 +0100 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1vWXVh-0000000320L-36RO; Fri, 19 Dec 2025 11:14:57 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum , Ahmad Fatoum Date: Fri, 19 Dec 2025 10:21:03 +0100 Message-ID: <20251219101453.2806980-28-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251219101453.2806980-1-a.fatoum@pengutronix.de> References: <20251219101453.2806980-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251219_023649_413551_3B18B9B4 X-CRM114-Status: GOOD ( 10.03 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v2025.09.y 27/49] sandbox: fix race with .old_version removal X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) From: Ahmad Fatoum On sandbox, .old_version is created and removed by the barebox.o recipe and the barebox ELF itself is never built and instead it's a symlink created by the barebox__ rule override. Drop the rm -f .old_version in that case, so the file is not removed too soon. A cleaner way would be to factor this logic out to a shell script like Linux does as it's serialized anyway and there's no benefit of having the steps as make targets, but that's left as future exercise. Signed-off-by: Ahmad Fatoum Link: https://lore.barebox.org/20251128104143.1578832-2-a.fatoum@pengutronix.de Signed-off-by: Sascha Hauer (cherry picked from commit d0c80df5b5378fca1e5f21387a5597ad9555ad40) Signed-off-by: Ahmad Fatoum --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index a6bff68a30e3..cc83061fccab 100644 --- a/Makefile +++ b/Makefile @@ -1047,7 +1047,9 @@ PHONY += install # barebox image barebox: $(BAREBOX_LDS) $(BAREBOX_OBJS) $(kallsyms.o) FORCE $(call if_changed_rule,barebox__) +ifeq ($(BAREBOX_PROPER),barebox) $(Q)rm -f .old_version +endif barebox.fit: images/barebox-$(CONFIG_ARCH_LINUX_NAME).fit $(Q)ln -fsn $< $@ -- 2.47.3