From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 19 Dec 2025 11:37:55 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vWXrv-00DAZv-2S for lore@lore.pengutronix.de; Fri, 19 Dec 2025 11:37:55 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vWXrj-0005gT-QP for lore@pengutronix.de; Fri, 19 Dec 2025 11:37:55 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ikonVKFuJhKEV6DbF2N/vtxRGO242Y+1RmmsiOV9uVg=; b=Cnweescr610YpwOYeeN+GB/gSw J3JbQ9JG96zwE5Fj8+hwK0WZpALAwtIo3JLft8LJAqaf7mNaTWTp4sA2/MMj5rwoMnnKHt4lBOLiG pEaNofeMU3unWHKtFXWZ7we/aIgO01XFY7esUbZ8NUP6lmaCfVI4xdaULI+SVIaDr3VbqRTnjIMpk uFRUVnHgBuQNkKYN8G5Na73c1VxclrfyqzUlHsjWig3UnNyyzeDU1oe5NKUAQvHZYJs0D9gzX9LFM mDORt7K1Nq07hG6pKXiRbFSPLTfm6EHcNiXJQKlt4VDJI1UZhfpM0acH80RyWB/MMoIrrb7jvDWaK 0Zk2q5cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vWXqt-0000000A5ys-2uUD; Fri, 19 Dec 2025 10:36:51 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vWXqr-0000000A5uc-1Gzu for barebox@lists.infradead.org; Fri, 19 Dec 2025 10:36:50 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vWXqp-0004Yx-Pf; Fri, 19 Dec 2025 11:36:47 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vWXqp-006RU6-1u; Fri, 19 Dec 2025 11:36:47 +0100 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1vWXVi-0000000320L-0qxd; Fri, 19 Dec 2025 11:14:58 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Jonas Rebmann , Ahmad Fatoum Date: Fri, 19 Dec 2025 10:21:13 +0100 Message-ID: <20251219101453.2806980-38-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251219101453.2806980-1-a.fatoum@pengutronix.de> References: <20251219101453.2806980-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251219_023649_346931_EA3B1A46 X-CRM114-Status: GOOD ( 10.69 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v2025.09.y 37/49] tlv: register_device() error handling X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) From: Jonas Rebmann register_device() returns 0 on success, or an error, which must be handled appropriately. Signed-off-by: Jonas Rebmann Link: https://lore.barebox.org/20251201-tlv-hardening-v1-1-5dcaa5f7aed5@pengutronix.de Signed-off-by: Sascha Hauer (cherry picked from commit debc16173615aacedd389152ce400096b6f49c5f) Signed-off-by: Ahmad Fatoum --- common/tlv/bus.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/common/tlv/bus.c b/common/tlv/bus.c index 4dbffd365667..7ca4f82fcf18 100644 --- a/common/tlv/bus.c +++ b/common/tlv/bus.c @@ -21,6 +21,7 @@ struct tlv_device *tlv_register_device(struct tlv_header *header, const char *name = NULL; struct device *dev; static int id = 0; + int ret; tlvdev = xzalloc(sizeof(*tlvdev)); @@ -44,7 +45,11 @@ struct tlv_device *tlv_register_device(struct tlv_header *header, dev->device_node = of_new_node(of_new_node(NULL, NULL), dev_name(dev)); dev->device_node->dev = dev; - register_device(dev); + ret = register_device(dev); + if (ret) { + free(tlvdev); + return ERR_PTR(ret); + } return tlvdev; } -- 2.47.3