mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michael Tretter <m.tretter@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	 BAREBOX <barebox@lists.infradead.org>
Cc: Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH 4/4] arm: socfpga: mailbox_s10: handle error 0x8f explicitly
Date: Wed, 11 Mar 2026 12:06:42 +0100	[thread overview]
Message-ID: <20260311-agilex5-qspi-v1-4-be8a8e1318e1@pengutronix.de> (raw)
In-Reply-To: <20260311-agilex5-qspi-v1-0-be8a8e1318e1@pengutronix.de>

The 0x8f is a command specific error code that indicates that the SDM
denied the HPS direct access to the QSPI. This is a valid SDM
configuration, but prevents barebox from using the QSPI flash, which may
or may not be a problem.

This configuration may also happen accidentally when using Quartus 25.3
to add a FSBL to a board SDM configuration created by Quartus 24.3.

Print a specific error message for this situation to help the developer.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 arch/arm/mach-socfpga/mailbox_s10.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-socfpga/mailbox_s10.c b/arch/arm/mach-socfpga/mailbox_s10.c
index ff2f261014b2..4199c4fb913a 100644
--- a/arch/arm/mach-socfpga/mailbox_s10.c
+++ b/arch/arm/mach-socfpga/mailbox_s10.c
@@ -319,7 +319,13 @@ int socfpga_mailbox_s10_qspi_open(void)
 	/* HPS will directly control the QSPI controller, no longer mailbox */
 	ret = mbox_send_cmd(MBOX_ID_BAREBOX, MBOX_QSPI_DIRECT, MBOX_CMD_DIRECT,
 			    0, NULL, 0, &resp_buf_len, resp_buf);
-	if (ret) {
+	switch (ret) {
+	case MBOX_RESP_STATOK:
+		break;
+	case 0x8f:
+		pr_err("QSPI: SDM denied direct QSPI access\n");
+		goto error;
+	default:
 		pr_err("QSPI: QSPI_DIRECT failed: 0x%x\n", ret);
 		goto error;
 	}

-- 
2.47.3




  parent reply	other threads:[~2026-03-11 11:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 11:06 [PATCH 0/4] arm: socfpga: mailbox_s10: cleanup and error handling Michael Tretter
2026-03-11 11:06 ` [PATCH 1/4] arm: socfpga: mailbox_s10: make retry logic more visible Michael Tretter
2026-03-11 11:06 ` [PATCH 2/4] arm: socfpga: mailbox_s10: cleanup send command Michael Tretter
2026-03-11 11:06 ` [PATCH 3/4] arm: socfpga: mailbox_s10: add error messages for QSPI Michael Tretter
2026-03-11 11:06 ` Michael Tretter [this message]
2026-03-13 14:39 ` [PATCH 0/4] arm: socfpga: mailbox_s10: cleanup and error handling Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260311-agilex5-qspi-v1-4-be8a8e1318e1@pengutronix.de \
    --to=m.tretter@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox