From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 13 Mar 2026 14:33:54 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w12eI-000DKH-0P for lore@lore.pengutronix.de; Fri, 13 Mar 2026 14:33:54 +0100 Received: from bombadil.infradead.org ([198.137.202.133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w12dy-00081W-3v for lore@pengutronix.de; Fri, 13 Mar 2026 14:33:53 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VZORrMcdXW/n2jHf5BQQf5p2rRpbhLnPfNdGlbKuxsE=; b=YGCQvRYAwyCX2AkA4w/bivfv8P afVjBl5f4VsS/oMGc3h5xs7572pVam5WG5jBeW3x9F4gWUej5seo9FTTwPn8G5qre4FkKHC3oH8U1 1sOmUK48jakikuGUpqDDznJbz9gNe3U+0eTYVcHhTg1W/WVtuKh6w5w3YulteBFYuhSKfZav+JPNn RUGN+vXMRNfQjfLOV1aKq7BTq+lloN9K0bzDN8IuW3ThTk6wPGYA1nIs2oeYHfahdluIA4DTcAxyO aCDqzh9sB3lsBSoEgbyqObO9bhkOrMy3xqWmjhNyJ1zq7uGw2XmJoJeUr8CeC4Ageo63XeICbPw/o FCfVq4Ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w12d8-00000000FYz-3xgR; Fri, 13 Mar 2026 13:32:42 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w12d5-00000000FVa-3j0t for barebox@bombadil.infradead.org; Fri, 13 Mar 2026 13:32:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=VZORrMcdXW/n2jHf5BQQf5p2rRpbhLnPfNdGlbKuxsE=; b=Qxq5bIGDiwH+9GhDCGG/4MiRu5 DQLQwDwoHgnegGMHHcaoWZgUiTpFjzq2p82kQYc/QsBfBFSvNKRh8/W4AWlGRReqJQXDmp4a4sevA lXVjOBMaGo39vCobuT9F5a3dyEUxTkT2X+d4gNMA+YXejPp6wfdt5WZHzjyFqCi8hzPmrtAj6dQt7 u7yY5D1OsDHrN/HQ1t/2rsyDKwBCmYwcVS7laC2iIrhWiDhSrrmr4IqgKis660JgGAPiKiXEvB40+ qlr8gOHGHxJGORouzPT/7cqcctkCTpOgH37mnsCn1FbO5N+VpatQ9bghdbXmMc2SEu+YO/YkR6Rat t5k8U61A==; Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by casper.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w12d2-0000000D9w6-0Pgf for barebox@lists.infradead.org; Fri, 13 Mar 2026 13:32:38 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w12cz-0006q6-1X; Fri, 13 Mar 2026 14:32:33 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w12cy-0005TR-2W; Fri, 13 Mar 2026 14:32:32 +0100 Received: from [::1] (helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1w12XM-00000009ULB-0YtW; Fri, 13 Mar 2026 14:26:44 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum , "Claude Opus 4.6" Date: Fri, 13 Mar 2026 14:25:26 +0100 Message-ID: <20260313132631.2257573-43-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260313132631.2257573-1-a.fatoum@pengutronix.de> References: <20260313132631.2257573-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260313_133236_164657_AABA428F X-CRM114-Status: UNSURE ( 8.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 198.137.202.133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.2 Subject: [PATCH v2025.09.y 42/58] mci: imx-esdhc: remove misleading NULL check for cmd pointer X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) The ternary `cmd ? cmd->cmdidx : 0` suggests cmd can be NULL, but all callers always pass a valid pointer and sdhci_set_cmd_xfer_mode() unconditionally dereferences cmd a few lines later. Remove the unnecessary guard to make the code consistent. (cherry picked from commit 2a7768ce1640575f175760296ec033eee26a07af) Reported-by: GCC 14.2 -fanalyzer Co-Authored-By: Claude Opus 4.6 Signed-off-by: Ahmad Fatoum Link: https://lore.barebox.org/20260216084253.3547270-11-a.fatoum@pengutronix.de Signed-off-by: Sascha Hauer --- drivers/mci/imx-esdhc-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mci/imx-esdhc-common.c b/drivers/mci/imx-esdhc-common.c index 66f3edc670e0..050621d7fb06 100644 --- a/drivers/mci/imx-esdhc-common.c +++ b/drivers/mci/imx-esdhc-common.c @@ -327,7 +327,7 @@ int __esdhc_send_cmd(struct fsl_esdhc_host *host, struct mci_cmd *cmd, dma_addr_t dma = SDHCI_NO_DMA; int ret; - host->last_cmd = cmd ? cmd->cmdidx : 0; + host->last_cmd = cmd->cmdidx; sdhci_write32(&host->sdhci, SDHCI_INT_STATUS, -1); -- 2.47.3