From: Sascha Hauer <s.hauer@pengutronix.de>
To: BAREBOX <barebox@lists.infradead.org>
Subject: [PATCH 8/9] ARM: Rockchip: Use compressed OP-TEE binary
Date: Mon, 16 Mar 2026 18:21:21 +0100 [thread overview]
Message-ID: <20260316-compressed-firmware-v1-8-d9712142881e@pengutronix.de> (raw)
In-Reply-To: <20260316-compressed-firmware-v1-0-d9712142881e@pengutronix.de>
Rockchip images are often size constraint due to the ROM limiting the
maximum image size to 2MiB, at least when redundant copies on SD/eMMC
are desired. For this reason use the compressed variant of the OP-TEE
image.
FIXME: Uncompress address currently hardcoded.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/mach-rockchip/atf.c | 26 ++++++++++++++++++++------
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-rockchip/atf.c b/arch/arm/mach-rockchip/atf.c
index 0d26dfb740..2ba7f074ce 100644
--- a/arch/arm/mach-rockchip/atf.c
+++ b/arch/arm/mach-rockchip/atf.c
@@ -8,6 +8,7 @@
#include <asm/atf_common.h>
#include <asm/barebox-arm.h>
#include <asm-generic/memory_layout.h>
+#include <asm-generic/sections.h>
#include <mach/rockchip/dmc.h>
#include <mach/rockchip/rockchip.h>
#include <mach/rockchip/bootrom.h>
@@ -29,7 +30,12 @@ static void rk_scratch_save_optee_hdr(const struct optee_header *hdr)
rk_scratch->optee_hdr = *hdr;
}
-static unsigned long load_elf64_image_phdr(const void *elf)
+static void *free_mem(void)
+{
+ return (void *)PTR_ALIGN(&__image_end, SZ_1M);
+}
+
+static unsigned long load_elf64_image_phdr(struct fwobj *bl31)
{
const Elf64_Ehdr *ehdr; /* Elf header structure pointer */
const Elf64_Phdr *phdr; /* Program header structure pointer */
@@ -56,11 +62,17 @@ static unsigned long load_elf64_image_phdr(const void *elf)
return ehdr->e_entry;
}
-static uintptr_t rk_load_optee(uintptr_t bl32, const void *bl32_image,
- size_t bl32_size)
+static uintptr_t rk_load_optee(uintptr_t bl32, struct fwobj *bl32_fw)
{
- const struct optee_header *hdr = bl32_image;
+ const struct optee_header *hdr;
struct optee_header dummy_hdr;
+ int ret;
+ void *bl32_image = free_mem();
+ size_t bl32_size = bl32_fw->uncompressed_size;
+
+ ret = fwobj_uncompress(bl32_fw, bl32_image);
+ if (ret)
+ panic("Failed to uncompress OP-TEE\n");
/* We already have ELF support for BL31, but adding it for BL32,
* would require us to identify a range that fits all ELF
@@ -70,6 +82,8 @@ static uintptr_t rk_load_optee(uintptr_t bl32, const void *bl32_image,
*/
BUG_ON(memcmp(bl32_image, ELFMAG, 4) == 0);
+ hdr = bl32_image;
+
if (optee_verify_header(hdr) == 0) {
bl32_size -= sizeof(*hdr);
bl32_image += sizeof(*hdr);
@@ -119,7 +133,7 @@ static struct fwobj bl32; /* OP-TEE in barebox image */
optee_load_address = SOC##_OPTEE_LOAD_ADDRESS; \
get_builtin_firmware(atf_bin, &bl31); \
if (IS_ENABLED(CONFIG_ARCH_ROCKCHIP_OPTEE)) \
- get_builtin_firmware(tee_bin, &bl32); \
+ get_builtin_firmware_compressed(tee_bin, &bl32); \
} while (0)
@@ -130,7 +144,7 @@ static void rockchip_atf_load_bl31(void *fdt)
bl31_ep = load_elf64_image_phdr(bl31.data);
if (IS_ENABLED(CONFIG_ARCH_ROCKCHIP_OPTEE))
- optee_load_address = rk_load_optee(optee_load_address, bl32.data, bl32.size);
+ optee_load_address = rk_load_optee(optee_load_address, &bl32);
/* Setup an initial stack for EL2 */
asm volatile("msr sp_el2, %0" : :
--
2.47.3
next prev parent reply other threads:[~2026-03-16 17:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 17:21 [PATCH 0/9] Firmware: support compressing firmware files Sascha Hauer
2026-03-16 17:21 ` [PATCH 1/9] ARM: socfpga: Drop unnecessary select USE_COMPRESSED_DTB Sascha Hauer
2026-03-16 17:21 ` [PATCH 2/9] ARM: radxa-rock5: Use compressed DTB Sascha Hauer
2026-03-16 17:21 ` [PATCH 3/9] ARM: Rockchip: Simplify retrieval of SoC specific addresses Sascha Hauer
2026-03-16 17:21 ` [PATCH 4/9] firmware: Move firmware assembly generation to scripts/gen-fw-s Sascha Hauer
2026-03-16 17:21 ` [PATCH 5/9] firmware: Use struct fwobj for get_builtin_firmware APIs Sascha Hauer
2026-03-16 17:21 ` [PATCH 6/9] firmware: Add compressed firmware symbols for PBL Sascha Hauer
2026-03-19 14:19 ` [PATCH] fixup! " Sascha Hauer
2026-03-20 8:54 ` Sascha Hauer
2026-03-16 17:21 ` [PATCH 7/9] firmware: Add fwobj_uncompress() for decompressing firmware in PBL Sascha Hauer
2026-03-16 17:21 ` Sascha Hauer [this message]
2026-03-18 8:10 ` [PATCH 8/9] ARM: Rockchip: Use compressed OP-TEE binary Sascha Hauer
2026-03-16 17:21 ` [PATCH 9/9] ARM: Rockchip: Use compressed TF-A binary Sascha Hauer
2026-03-19 6:53 ` [PATCH 0/9] Firmware: support compressing firmware files Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316-compressed-firmware-v1-8-d9712142881e@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox