From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Alexander Shiyan <eagle.alexander923@gmail.com>,
Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 1/3] common: fix help text reference to internal imagicvars
Date: Tue, 5 May 2026 11:50:58 +0200 [thread overview]
Message-ID: <20260505095137.1123867-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20260505095137.1123867-1-a.fatoum@pengutronix.de>
Both ${global.linux.bootargs.bootm.appendroot} and
${global.linux.bootargs.machine_id} are magic vars internally populated
by barebox to hold the computed root= or systemd.machine_id options.
They are out of place in the help text as they are an implementation
detail and not user API. In the case of CONFIG_MMCBLKDEV_ROOTARG, it's
even incorrect as the help text is talking about what a user can do to
trigger the root= appending and that should be either
global.bootm.appendroot=1 or adding linux-appendroot to the blspec file.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
common/Kconfig | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/common/Kconfig b/common/Kconfig
index fd422714d560..28a89265b386 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -769,7 +769,7 @@ config MMCBLKDEV_ROOTARG
kernel doesn't contain commit [1]. The first linux kernel release
containing that commit is v5.10-rc1.
- The appending only happens if barebox' 'linux.bootargs.bootm.appendroot'
+ The appending only happens if barebox' 'global.bootm.appendroot'
variable is set or the used blspec entry contains 'linux-appendroot'.
Note: It is crucial that the kernel device tree and the barebox device
@@ -1285,8 +1285,9 @@ config MACHINE_ID
updating barebox the machine id might change.
global.bootm.provide_machine_id may be used to automatically set
- the linux.bootargs.machine_id global variable with a value of
- systemd.machine_id=${global.machine_id}
+ fix up the kernel command line on boot with
+
+ systemd.machine_id=${global.machine_id}
Note: if no hashable information is available no machine id will be passed
to the kernel.
--
2.47.3
next prev parent reply other threads:[~2026-05-05 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 9:50 [PATCH 0/3] bootm: append automatic parameters after all other linux.bootargs Ahmad Fatoum
2026-05-05 9:50 ` Ahmad Fatoum [this message]
2026-05-05 9:50 ` [PATCH 2/3] Documentation: user: booting-linux: split off mtdparts fixup section Ahmad Fatoum
2026-05-05 9:51 ` [PATCH 3/3] bootm: append automatic parameters after all other linux.bootargs Ahmad Fatoum
2026-05-05 12:45 ` Alexander Shiyan
2026-05-07 11:17 ` (subset) " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505095137.1123867-2-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eagle.alexander923@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox