From: Michael Tretter <m.tretter@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH 4/6] arm: socfpga: mailbox_s10: keep clock rate in Hz
Date: Wed, 06 May 2026 11:06:10 +0200 [thread overview]
Message-ID: <20260506-socfpga-agilex5-qspi-v1-4-94def85c1b80@pengutronix.de> (raw)
In-Reply-To: <20260506-socfpga-agilex5-qspi-v1-0-94def85c1b80@pengutronix.de>
The QSPI reference clock rate is retrieved in Hz from the firmware, but
stored in kHz in a handover register.
Initially, the clock rated is stored as Hz in clk_khz, and later
converted to kHz before printing and storing it. Initially the warning
prints the clock rate in Hz, but prints kHz as unit. This is confusing.
Leave the clock rate in Hz, and convert it to kHz when used.
Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
arch/arm/mach-socfpga/mailbox_s10.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-socfpga/mailbox_s10.c b/arch/arm/mach-socfpga/mailbox_s10.c
index 4199c4fb913a..c6ea081165d4 100644
--- a/arch/arm/mach-socfpga/mailbox_s10.c
+++ b/arch/arm/mach-socfpga/mailbox_s10.c
@@ -300,7 +300,7 @@ int socfpga_mailbox_s10_qspi_open(void)
u32 resp_buf[1] = {};
u32 resp_buf_len = ARRAY_SIZE(resp_buf);
u32 reg;
- u32 clk_khz;
+ u32 clk_rate;
int try = 0;
retry:
@@ -331,20 +331,19 @@ int socfpga_mailbox_s10_qspi_open(void)
}
/* Get the QSPI clock from SDM response and save for later use */
- clk_khz = resp_buf[0];
- if (clk_khz < 1000) {
- pr_err("QSPI: Unexpected reference clock rate: %d kHz\n",
- clk_khz);
+ clk_rate = resp_buf[0];
+ if (clk_rate < 1000) {
+ pr_err("QSPI: Unexpected reference clock rate: %d Hz\n",
+ clk_rate);
return -EINVAL;
}
- clk_khz /= 1000;
- pr_info("QSPI: reference clock at %d kHz\n", clk_khz);
+ pr_info("QSPI: reference clock at %d kHz\n", clk_rate / 1000);
reg = (readl(SOCFPGA_SYSMGR_ADDRESS + SYSMGR_SOC64_BOOT_SCRATCH_COLD0)) &
~(SYSMGR_SCRATCH_REG_0_QSPI_REFCLK_MASK);
- writel((clk_khz & SYSMGR_SCRATCH_REG_0_QSPI_REFCLK_MASK) | reg,
+ writel(((clk_rate / 1000) & SYSMGR_SCRATCH_REG_0_QSPI_REFCLK_MASK) | reg,
SOCFPGA_SYSMGR_ADDRESS + SYSMGR_SOC64_BOOT_SCRATCH_COLD0);
return 0;
--
2.47.3
next prev parent reply other threads:[~2026-05-06 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 9:06 [PATCH 0/6] arm: socfpga: agilex5: cleanup QSPI flash low level code Michael Tretter
2026-05-06 9:06 ` [PATCH 1/6] arm: socfpga: agilex5: add missing include soc64-regs.h Michael Tretter
2026-05-06 9:06 ` [PATCH 2/6] arm: socfgpa: agilex5: remove mailbox_s10 from barebox proper Michael Tretter
2026-05-06 9:06 ` [PATCH 3/6] arm: socfpga: agilex5: extract function to request qspi access Michael Tretter
2026-05-06 9:06 ` Michael Tretter [this message]
2026-05-06 9:06 ` [PATCH 5/6] arm: socfpga: mailbox_s10: add write_qspi_refclk helper Michael Tretter
2026-05-06 9:06 ` [PATCH 6/6] arm: socfpga: agilex5: extract write_qspi_refclk from mailbox Michael Tretter
2026-05-07 10:48 ` [PATCH 0/6] arm: socfpga: agilex5: cleanup QSPI flash low level code Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506-socfpga-agilex5-qspi-v1-4-94def85c1b80@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox