From: Michael Tretter <m.tretter@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH 2/5] arm: socfpga: agilex5: panic if DDR init failed
Date: Thu, 04 Jun 2026 13:06:55 +0200 [thread overview]
Message-ID: <20260604-socfpga-axe5-sdram-init-v1-2-274f6361ce98@pengutronix.de> (raw)
In-Reply-To: <20260604-socfpga-axe5-sdram-init-v1-0-274f6361ce98@pengutronix.de>
There is no point in continuing booting if the DDR initialization has
failed. Panic early to avoid obscure subsequent faults.
Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
arch/arm/mach-socfpga/atf.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-socfpga/atf.c b/arch/arm/mach-socfpga/atf.c
index 1fd11c426bc2..6ddfef34632f 100644
--- a/arch/arm/mach-socfpga/atf.c
+++ b/arch/arm/mach-socfpga/atf.c
@@ -63,6 +63,8 @@ static void __noreturn agilex5_load_and_start_image_via_tfa(void)
static void agilex5_el3_init(void)
{
+ int ret;
+
agilex5_initialize_security_policies();
pr_debug("Security policies initialized\n");
@@ -73,7 +75,9 @@ static void agilex5_el3_init(void)
*/
if (!IS_ENABLED(CONFIG_DEBUG_LL))
writel(LCR_BKSE, SOCFPGA_UART0_ADDRESS + LCR);
- agilex5_ddr_init_full();
+ ret = agilex5_ddr_init_full();
+ if (ret)
+ panic("DDR initialization failed\n");
socfpga_agilex5_qspi_init();
--
2.47.3
next prev parent reply other threads:[~2026-06-04 11:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 11:06 [PATCH 0/5] arm: socfpga: agilex5: cleanup SDRAM initialization Michael Tretter
2026-06-04 11:06 ` [PATCH 1/5] arm: socfpga: agilex5: separate EL3 init function Michael Tretter
2026-06-04 11:06 ` Michael Tretter [this message]
2026-06-04 11:06 ` [PATCH 3/5] arm: socfpga: iossm: add delay to wait for firmware Michael Tretter
2026-06-04 11:06 ` [PATCH 4/5] arm: socfpga: agilex5: drop dual port hack Michael Tretter
2026-06-04 11:06 ` [PATCH 5/5] arm: socfpga: agilex5: drop bank select before ddr_init Michael Tretter
2026-06-05 6:13 ` [PATCH 0/5] arm: socfpga: agilex5: cleanup SDRAM initialization Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604-socfpga-axe5-sdram-init-v1-2-274f6361ce98@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox