From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 04 Jun 2026 13:53:43 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wV6dr-002GOM-2N for lore@lore.pengutronix.de; Thu, 04 Jun 2026 13:53:43 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wV6dr-0007QE-41 for lore@pengutronix.de; Thu, 04 Jun 2026 13:53:43 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jgJuOrCln6eG5kNK5J74XSS6E++h2QTPCrRYY/FIRsU=; b=loOlVnOEikXW8Jzz++FewiAw+u vgaJs5DPWrdxz2rEKhSAfWWJl88nXRlqDtXdYF9FLalZKHezCHOvO0m+QsEOf6cHdhZMWUUU+pK1z noLuY7BSvSc35UgeWv3FYnAPRMgXDgwAGUSTZIC+1y+JIZG6as5ZglfrMpbjMXqUq3ylDTebryyPz dHO6wYzAnzx0wGQa/JKuGZL+qiu0QfNooo27tLYt4LesUYHRBNfw2BIDLyxvXOrgHhFCy2G4Mk3Nv MCIcCWPB3XQqBn5FBxPH1hwcCYyMoKAZgU3Lzx00lUWcut5CPi62y1EFoHn5wb7liEeKxXSwDxNry nj7UAu0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wV5ul-0000000Gbz8-2k2y; Thu, 04 Jun 2026 11:07:07 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wV5ue-0000000GbwW-2ZbG for barebox@lists.infradead.org; Thu, 04 Jun 2026 11:07:06 +0000 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wV5uc-0000IX-Co; Thu, 04 Jun 2026 13:06:58 +0200 From: Michael Tretter Date: Thu, 04 Jun 2026 13:06:58 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260604-socfpga-axe5-sdram-init-v1-5-274f6361ce98@pengutronix.de> References: <20260604-socfpga-axe5-sdram-init-v1-0-274f6361ce98@pengutronix.de> In-Reply-To: <20260604-socfpga-axe5-sdram-init-v1-0-274f6361ce98@pengutronix.de> To: Sascha Hauer , BAREBOX Cc: Steffen Trumtrar , Michael Tretter X-Mailer: b4 0.14.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260604_040700_683568_29044C6A X-CRM114-Status: GOOD ( 10.45 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 5/5] arm: socfpga: agilex5: drop bank select before ddr_init X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) I verified that the bank select on UART0 is not necessary for the ddr_initialization. Thus, the documentation why the bank select is necessary is not valid anymore. Furthermore, depending on the UART used by the board, using UART0 may not be general enough, anyway. It seems like the bank select rather added a delay before the SDRAM initialization and without the bank select, the serial didn't show anything because the SDRAM initialization failed. Remove the workaround. Signed-off-by: Michael Tretter --- arch/arm/mach-socfpga/atf.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/arch/arm/mach-socfpga/atf.c b/arch/arm/mach-socfpga/atf.c index 6ddfef34632f..ac69fb7776ca 100644 --- a/arch/arm/mach-socfpga/atf.c +++ b/arch/arm/mach-socfpga/atf.c @@ -68,13 +68,6 @@ static void agilex5_el3_init(void) agilex5_initialize_security_policies(); pr_debug("Security policies initialized\n"); - /* - * need to set the bank select enable before the - * agilex5_ddr_init_full() otherwise the serial doesn't show - * anything. - */ - if (!IS_ENABLED(CONFIG_DEBUG_LL)) - writel(LCR_BKSE, SOCFPGA_UART0_ADDRESS + LCR); ret = agilex5_ddr_init_full(); if (ret) panic("DDR initialization failed\n"); -- 2.47.3