From: Michael Tretter <m.tretter@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Cc: Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH 3/3] arm: socfpga: axe5-eagle: always use UART0
Date: Fri, 05 Jun 2026 14:58:15 +0200 [thread overview]
Message-ID: <20260605-socfpga-debug-uart-v1-3-8454bfc709bf@pengutronix.de> (raw)
In-Reply-To: <20260605-socfpga-debug-uart-v1-0-8454bfc709bf@pengutronix.de>
Configuring debug_ll with the UART from the configuration, while
configuring the PBL console with a hard-coded address may lead to
inconsistencies and confusion.
Avoid this by explicitly configuring debug_ll with a UART defined by the
board low level code.
While at it, replace the address with the UART port macro.
Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
arch/arm/boards/arrow-axe5-eagle/lowlevel.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boards/arrow-axe5-eagle/lowlevel.c b/arch/arm/boards/arrow-axe5-eagle/lowlevel.c
index f946a8b9f616..b0a2d6673e0f 100644
--- a/arch/arm/boards/arrow-axe5-eagle/lowlevel.c
+++ b/arch/arm/boards/arrow-axe5-eagle/lowlevel.c
@@ -15,10 +15,12 @@ extern char __dtb_z_socfpga_agilex5_axe5_eagle_start[];
static noinline void axe5_eagle_continue(void)
{
+ void __iomem *uart = IOMEM(SOCFPGA_UART_BASE(0));
+
agilex5_clk_init();
- socfpga_uart_setup_ll();
- pbl_set_putc(socfpga_uart_putc, (void *) SOCFPGA_UART0_ADDRESS);
+ socfpga_uart_setup(uart);
+ pbl_set_putc(socfpga_uart_putc, uart);
pr_debug("Lowlevel init done\n");
--
2.47.3
prev parent reply other threads:[~2026-06-05 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 12:58 [PATCH 0/3] arm: socfpga: cleanup UART for serial console Michael Tretter
2026-06-05 12:58 ` [PATCH 1/3] arm: socfpga: replace custom UART with ns16550 Michael Tretter
2026-06-05 12:58 ` [PATCH 2/3] arm: socfpga: get rid of UART address for low-level debug Michael Tretter
2026-06-05 12:58 ` Michael Tretter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260605-socfpga-debug-uart-v1-3-8454bfc709bf@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox