mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@barebox.org>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: [PATCH 4/5] usb: separate descriptor and config requests
Date: Fri, 26 Jun 2026 19:31:40 +0200	[thread overview]
Message-ID: <20260626174342.1923132-5-a.fatoum@barebox.org> (raw)
In-Reply-To: <20260626174342.1923132-1-a.fatoum@barebox.org>

Port over U-Boot commit ef71290be9b70d8cfa63b506c7d93c5069f63c42:

|   usb: Assure Get Descriptor request is in separate microframe
|
|   The Kingston DT Ultimate USB 3.0 stick is sensitive to this first
|   Get Descriptor request and if the request is not in a separate
|   microframe, the stick refuses to operate. Add slight delay, which
|   is enough for one microframe to pass on any USB spec revision.
|
|   Signed-off-by: Marek Vasut <marex@denx.de>
|   Cc: Chin Liang See <clsee@altera.com>
|   Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
|   Cc: Hans de Goede <hdegoede@redhat.com>
|   Cc: Stefan Roese <sr@denx.de>
|   Cc: Stephen Warren <swarren@nvidia.com>

Assisted-by: Codex:gpt-5.5
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
 drivers/usb/core/usb.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
index 145b85a28fab..3f379197dc0c 100644
--- a/drivers/usb/core/usb.c
+++ b/drivers/usb/core/usb.c
@@ -522,6 +522,15 @@ int usb_new_device(struct usb_device *dev)
 	le16_to_cpus(&dev->descriptor->idVendor);
 	le16_to_cpus(&dev->descriptor->idProduct);
 	le16_to_cpus(&dev->descriptor->bcdDevice);
+
+	/*
+	 * Kingston DT Ultimate 32GB USB 3.0 seems to be extremely sensitive
+	 * about this first Get Descriptor request. If there are any other
+	 * requests in the first microframe, the stick crashes. Wait about
+	 * one microframe duration here (1mS for USB 1.x , 125uS for USB 2.0).
+	 */
+	mdelay(1);
+
 	/* only support for one config for now */
 	length = usb_get_configuration_no(dev, buf, 0);
 	if (length < 0) {
-- 
2.47.3




  parent reply	other threads:[~2026-06-26 17:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-26 17:31 [PATCH 0/5] usb: port over some U-Boot fixes Ahmad Fatoum
2026-06-26 17:31 ` [PATCH 1/5] usb: hub: wait after port reset recovery Ahmad Fatoum
2026-06-26 17:31 ` [PATCH 2/5] usb: wait after initial device descriptor read Ahmad Fatoum
2026-06-26 17:31 ` [PATCH 3/5] usb: wait after setting device configuration Ahmad Fatoum
2026-06-26 17:31 ` Ahmad Fatoum [this message]
2026-06-26 17:31 ` [PATCH 5/5] usb: hub: tolerate transient disconnects during reset Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260626174342.1923132-5-a.fatoum@barebox.org \
    --to=a.fatoum@barebox.org \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox