From: Ahmad Fatoum <a.fatoum@barebox.org>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: [PATCH master 1/3] efi: gop: fix rectangle extents passed to fb_damage
Date: Sat, 27 Jun 2026 11:55:39 +0200 [thread overview]
Message-ID: <20260627095543.2462939-1-a.fatoum@barebox.org> (raw)
fb_damage takes the coordinates of the upper left and bottom right
pixels as can be seen in fb_rect_width() and fb_rect_height().
We erroneously passed only width and height though, so add the origin
pixel coordinates on top to fix this.
Fixes: d040f49ad0b3 ("efi: loader: protocol: add graphical output protocol support")
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
efi/loader/protocols/gop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/efi/loader/protocols/gop.c b/efi/loader/protocols/gop.c
index 9ada8a2da290..d48edac5a2d6 100644
--- a/efi/loader/protocols/gop.c
+++ b/efi/loader/protocols/gop.c
@@ -248,7 +248,7 @@ static __always_inline efi_status_t gop_blt_int(struct efi_graphics_output_proto
}
if (blt_to_video) {
- struct fb_rect rect = { dx, dy, width, height };
+ struct fb_rect rect = { dx, dy, dx + width, dy + height };
fb_damage(gopobj->fbi, &rect);
}
--
2.47.3
next reply other threads:[~2026-06-27 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-27 9:55 Ahmad Fatoum [this message]
2026-06-27 9:55 ` [PATCH master 2/3] efi: gop: use correct BLT pixel type Ahmad Fatoum
2026-06-27 9:55 ` [PATCH master 3/3] efi: gop: report and use framebuffer stride Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260627095543.2462939-1-a.fatoum@barebox.org \
--to=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox