From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 2/4] commands: fix stale option strings in usage lines
Date: Mon, 24 Aug 2026 13:55:32 +0200 [thread overview]
Message-ID: <20260824115619.3148656-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20260824115619.3148656-1-a.fatoum@pengutronix.de>
The BAREBOX_CMD_OPTS strings of several commands have fallen out of sync
with the options their parsers actually accept.
Sync the usage lines with the getopt strings so the generated
documentation and the built-in help don't confuse users.
Assisted-by: Claude:fable-5
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
arch/arm/mach-at91/boot_test_cmd.c | 2 +-
commands/boot.c | 2 +-
commands/dmesg.c | 2 +-
commands/memset.c | 2 +-
commands/nandtest.c | 2 +-
commands/pwm.c | 2 +-
commands/splash.c | 2 +-
commands/ubiformat.c | 2 +-
efi/payload/init.c | 2 +-
9 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/mach-at91/boot_test_cmd.c b/arch/arm/mach-at91/boot_test_cmd.c
index 9a5c0e3e4e06..a5643c54915f 100644
--- a/arch/arm/mach-at91/boot_test_cmd.c
+++ b/arch/arm/mach-at91/boot_test_cmd.c
@@ -92,7 +92,7 @@ BAREBOX_CMD_HELP_END
BAREBOX_CMD_START(at91_boot_test)
.cmd = do_at91_boot_test,
BAREBOX_CMD_DESC("load and execute from SRAM")
- BAREBOX_CMD_OPTS("at91_boot_test [-js] FILE")
+ BAREBOX_CMD_OPTS("[-js] FILE")
BAREBOX_CMD_GROUP(CMD_GRP_BOOT)
BAREBOX_CMD_HELP(cmd_at91_boot_test_help)
BAREBOX_CMD_END
diff --git a/commands/boot.c b/commands/boot.c
index 17730cd35281..88a7aec32ea4 100644
--- a/commands/boot.c
+++ b/commands/boot.c
@@ -246,7 +246,7 @@ BAREBOX_CMD_HELP_END
BAREBOX_CMD_START(boot)
.cmd = do_boot,
BAREBOX_CMD_DESC("boot from script, device, ...")
- BAREBOX_CMD_OPTS("[-vdlmMwt] [BOOTSRC...]")
+ BAREBOX_CMD_OPTS("[-vdlmMwto] [BOOTSRC...]")
BAREBOX_CMD_GROUP(CMD_GRP_BOOT)
BAREBOX_CMD_HELP(cmd_boot_help)
BAREBOX_CMD_END
diff --git a/commands/dmesg.c b/commands/dmesg.c
index a2493acfacbc..b405cf4f1d13 100644
--- a/commands/dmesg.c
+++ b/commands/dmesg.c
@@ -189,7 +189,7 @@ BAREBOX_CMD_HELP_END
BAREBOX_CMD_START(dmesg)
.cmd = do_dmesg,
BAREBOX_CMD_DESC("Print or control log messages")
- BAREBOX_CMD_OPTS("[-cdelprt]")
+ BAREBOX_CMD_OPTS("[-cdelnprt]")
BAREBOX_CMD_GROUP(CMD_GRP_INFO)
BAREBOX_CMD_HELP(cmd_dmesg_help)
BAREBOX_CMD_END
diff --git a/commands/memset.c b/commands/memset.c
index f26d0e9fe18c..ac6b7344d55d 100644
--- a/commands/memset.c
+++ b/commands/memset.c
@@ -86,7 +86,7 @@ BAREBOX_CMD_HELP_END
BAREBOX_CMD_START(memset)
.cmd = do_memset,
BAREBOX_CMD_DESC("memory fill")
- BAREBOX_CMD_OPTS("[-bwlq [-d FILE] ADDR DATA COUNT")
+ BAREBOX_CMD_OPTS("[-bwlq] [-d FILE] ADDR DATA COUNT")
BAREBOX_CMD_GROUP(CMD_GRP_MEM)
BAREBOX_CMD_HELP(cmd_memset_help)
BAREBOX_CMD_END
diff --git a/commands/nandtest.c b/commands/nandtest.c
index 61deb7bad5c4..359401f98e86 100644
--- a/commands/nandtest.c
+++ b/commands/nandtest.c
@@ -407,7 +407,7 @@ BAREBOX_CMD_HELP_END
BAREBOX_CMD_START(nandtest)
.cmd = do_nandtest,
BAREBOX_CMD_DESC("NAND flash memory test")
- BAREBOX_CMD_OPTS("[-tmsiol] NANDDEVICE")
+ BAREBOX_CMD_OPTS("[-trmsiol] NANDDEVICE")
BAREBOX_CMD_GROUP(CMD_GRP_HWMANIP)
BAREBOX_CMD_HELP(cmd_nandtest_help)
BAREBOX_CMD_END
diff --git a/commands/pwm.c b/commands/pwm.c
index fec6abe82576..6e0ba2c2e36f 100644
--- a/commands/pwm.c
+++ b/commands/pwm.c
@@ -206,7 +206,7 @@ BAREBOX_CMD_HELP_END
BAREBOX_CMD_START(pwm)
.cmd = do_pwm_cmd,
BAREBOX_CMD_DESC("pwm")
- BAREBOX_CMD_OPTS("[-ldDPfwisv]")
+ BAREBOX_CMD_OPTS("[-ldDPfwFisv]")
BAREBOX_CMD_GROUP(CMD_GRP_HWMANIP)
BAREBOX_CMD_HELP(cmd_pwm_help)
BAREBOX_CMD_END
diff --git a/commands/splash.c b/commands/splash.c
index dffe29f92328..4eba681384b0 100644
--- a/commands/splash.c
+++ b/commands/splash.c
@@ -97,7 +97,7 @@ BAREBOX_CMD_HELP_END
BAREBOX_CMD_START(splash)
.cmd = do_splash,
BAREBOX_CMD_DESC("display a BMP or PNG splash image")
- BAREBOX_CMD_OPTS("[-fxyno] FILE")
+ BAREBOX_CMD_OPTS("[-fxyb] FILE")
BAREBOX_CMD_GROUP(CMD_GRP_CONSOLE)
BAREBOX_CMD_HELP(cmd_splash_help)
BAREBOX_CMD_END
diff --git a/commands/ubiformat.c b/commands/ubiformat.c
index cb52cd9f6aac..a9b79b711f5d 100644
--- a/commands/ubiformat.c
+++ b/commands/ubiformat.c
@@ -192,7 +192,7 @@ BAREBOX_CMD_HELP_END
BAREBOX_CMD_START(ubiformat)
.cmd = do_ubiformat,
BAREBOX_CMD_DESC("format an ubi volume")
- BAREBOX_CMD_OPTS("[-sOnfexQqv] MTDEVICE")
+ BAREBOX_CMD_OPTS("[-sOnfexQyqv] MTDEVICE")
BAREBOX_CMD_GROUP(CMD_GRP_PART)
BAREBOX_CMD_HELP(cmd_ubiformat_help)
BAREBOX_CMD_END
diff --git a/efi/payload/init.c b/efi/payload/init.c
index 6d2bd046e4c2..862ca6a3e7d6 100644
--- a/efi/payload/init.c
+++ b/efi/payload/init.c
@@ -356,7 +356,7 @@ BAREBOX_CMD_HELP_END
BAREBOX_CMD_START(efiexit)
.cmd = do_efiexit,
BAREBOX_CMD_DESC("Leave barebox and return to the calling EFI process")
- BAREBOX_CMD_OPTS("[-flrw]")
+ BAREBOX_CMD_OPTS("[-f]")
BAREBOX_CMD_GROUP(CMD_GRP_MISC)
BAREBOX_CMD_HELP(cmd_efiexit_help)
BAREBOX_CMD_END
--
2.47.3
next prev parent reply other threads:[~2026-08-24 11:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 11:55 [PATCH 1/4] commands: fix typos and punctuation in help texts Ahmad Fatoum
2026-08-24 11:55 ` Ahmad Fatoum [this message]
2026-08-24 11:55 ` [PATCH 3/4] commands: fix wrong and incomplete " Ahmad Fatoum
2026-08-24 11:55 ` [PATCH 4/4] Documentation: gen_commands: deduplicate entries from multiple definitions Ahmad Fatoum
2026-08-24 12:30 ` [PATCH 1/4] commands: fix typos and punctuation in help texts Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260824115619.3148656-2-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox