mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Stephano Cetola <stephano@cetola.net>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	 "open list:BAREBOX" <barebox@lists.infradead.org>
Subject: [PATCH] extlinux: recognize LINUX as an alias for KERNEL
Date: Tue, 25 Aug 2026 17:38:33 -0700	[thread overview]
Message-ID: <20260825-send-extlinux-linux-keyword-v1-1-e2d0b9f291d4@cetola.net> (raw)

Syslinux configs commonly use LINUX instead of KERNEL to name the
kernel image. parse_extlinux_conf() only checked for KERNEL, so a
LABEL block using LINUX left entry->kernel unset. parse_extlinux_conf()
requires a kernel path to accept an entry, so the whole extlinux.conf
was rejected instead of just the one line being ignored.

Fixes: b912fa9fc3ca ("Add support for extlinux.conf")
Signed-off-by: Stephano Cetola <stephano@cetola.net>
---
 common/extlinux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/extlinux.c b/common/extlinux.c
index caa62923da..92c49ebbce 100644
--- a/common/extlinux.c
+++ b/common/extlinux.c
@@ -132,7 +132,7 @@ static struct extlinux_entry *parse_extlinux_conf(const char *abspath,
 		}
 
 		if (entry) {
-			if (!strcasecmp(key, "KERNEL"))
+			if (!strcasecmp(key, "KERNEL") || !strcasecmp(key, "LINUX"))
 				entry->kernel = xstrdup(val);
 			else if (!strcasecmp(key, "INITRD"))
 				entry->initrd = xstrdup(val);

---
base-commit: 9bc1a26592a59919d2ee8c60c273d87d3d9f2e81
change-id: 20260822-send-extlinux-linux-keyword-ce52ee90d321




             reply	other threads:[~2026-08-26  0:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26  0:38 Stephano Cetola [this message]
2026-08-28 10:10 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260825-send-extlinux-linux-keyword-v1-1-e2d0b9f291d4@cetola.net \
    --to=stephano@cetola.net \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox