From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 26 Aug 2026 11:38:15 +0200 Received: from mx1.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::107]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wzA5G-007O2X-0r for lore@lore.pengutronix.de; Wed, 26 Aug 2026 11:38:15 +0200 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPS id E12AD202107 for ; Wed, 26 Aug 2026 11:38:14 +0200 (CEST) Authentication-Results: mx1.white.stw.pengutronix.de; dkim=pass header.d=lists.infradead.org header.s=bombadil.20210309 header.b=37Gv+hz+; dmarc=none; spf=pass (mx1.white.stw.pengutronix.de: domain of "barebox-bounces+lore=pengutronix.de@lists.infradead.org" designates 2607:7c80:54:3::133 as permitted sender) smtp.mailfrom="barebox-bounces+lore=pengutronix.de@lists.infradead.org" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=yaIsi4I5kzjf78IAdfaAFq9xhh3a4PVDCIJaS3RdnLs=; b=37Gv+hz+o3adnBbwV541BOTV/U 1MvW6H2znanglz30UpISl5trVCK0rnlNlZEsE2e2IVT/fa4su0I3UhScKKO95T5oMZmAFpsWd3AiC EqLGOwC32B2LFPHs4kjB6h4sQzpS58Sl8ZWLDTrQjZ3hjL+HZM9aI1/7u2MdnLPiYR082m6iM6FZ2 JOOMDbu3cgpx813zJRkFxdhB3zCdF/UzLMPW0Fbja8hjbtfmB8fn/0+YQlS4/sPw7HixDecdgP/w6 IkD/bSVCB/nrKqIH8Eh6+gZGOYl76LhMQKREYW+I0jdir+dhuQ5EfaBfqik5D1uUd/4UHbwNObJ+y wmfTQW+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzA4D-00000002DDQ-2cJM; Wed, 26 Aug 2026 09:37:09 +0000 Received: from mx1.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::107]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzA48-00000002DBK-3qT3 for barebox@lists.infradead.org; Wed, 26 Aug 2026 09:37:07 +0000 Received: from drehscheibe.grey.stw.pengutronix.de (drehscheibe.grey.stw.pengutronix.de [IPv6:2a0a:edc0:0:c01:1d::a2]) (Authenticated sender: relay-from-drehscheibe.grey.stw.pengutronix.de) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPSA id E816C202040; Wed, 26 Aug 2026 11:37:02 +0200 (CEST) Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wzA46-003Pz2-2n; Wed, 26 Aug 2026 11:37:02 +0200 Received: from [::1] (helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1wzA46-0000000ARid-3DUQ; Wed, 26 Aug 2026 11:37:02 +0200 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Subject: [PATCH master 1/4] efi: loader: don't truncate the status in efi_init_runtime_variable_supported() Date: Wed, 26 Aug 2026 11:36:48 +0200 Message-ID: <20260826093701.2486248-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260826_023705_106312_F86648E7 X-CRM114-Status: GOOD ( 10.60 ) X-Spam-Score: -1.9 (-) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The return values of efi_set_variable_int() are efi_status_t, i.e. 64-bit on 64-bit targets with the error bit in the topmost bit. Collecting them in an int drops that bit, so the value returned to ef [...] Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 DMARC_MISSING Missing DMARC policy X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-Spamd-Result: default: False [-56.21 / 15.00]; RECEIVED_AUTHENTICATED_BY_MX1(-50.00)[]; BAYES_HAM(-3.00)[99.99%]; DWL_DNSWL_MED(-2.00)[infradead.org:dkim]; KNOWN_LIST_ID(-1.00)[barebox.lists.infradead.org]; MID_CONTAINS_FROM(1.00)[]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; R_MISSING_CHARSET(0.50)[]; RCVD_IN_DNSWL_MED(-0.40)[2607:7c80:54:3::133:from,2a0a:edc0:0:1101:1d::54:received]; MAILLIST(-0.20)[mailman]; R_SPF_ALLOW(-0.20)[+mx:c]; R_DKIM_ALLOW(-0.20)[lists.infradead.org:s=bombadil.20210309]; RCVD_IN_DNSWL_LOW(-0.10)[2a0a:edc0:0:c01:1d::a2:received]; MIME_GOOD(-0.10)[text/plain]; HAS_LIST_UNSUB(-0.01)[]; RCPT_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RECEIVED_HELO_LOCALHOST(0.00)[]; DMARC_NA(0.00)[pengutronix.de]; DKIM_TRACE(0.00)[lists.infradead.org:+]; TAGGED_FROM(0.00)[lore=pengutronix.de]; FROM_NEQ_ENVFROM(0.00)[a.fatoum@pengutronix.de,barebox-bounces@lists.infradead.org]; FROM_HAS_DN(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM(-0.00)[-1.000]; ASN(0.00)[asn:7247, ipnet:2607:7c80:54::/48, country:US]; FORGED_SENDER_MAILLIST(0.00)[] X-Rspamd-Action: no action X-Rspamd-Server: mx1 X-Stat-Signature: ucm7j6xfk5besp6o5nzg8gmpaipa84n3 X-Rspamd-Queue-Id: E12AD202107 The return values of efi_set_variable_int() are efi_status_t, i.e. 64-bit on 64-bit targets with the error bit in the topmost bit. Collecting them in an int drops that bit, so the value returned to efi_init_runtime_supported() is a small positive number that no longer identifies an EFI error: EFI_OUT_OF_RESOURCES arrives as 9. Callers only compared against EFI_SUCCESS so far, which happens to still work, but the status is worth printing and the next commit does so. Assisted-by: Claude:opus-5 Signed-off-by: Ahmad Fatoum --- efi/loader/efi_var_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/efi/loader/efi_var_file.c b/efi/loader/efi_var_file.c index 12543bce2851..fbafd901bd0c 100644 --- a/efi/loader/efi_var_file.c +++ b/efi/loader/efi_var_file.c @@ -191,8 +191,8 @@ efi_status_t efi_var_from_file(int dirfd, const char *filename) efi_status_t efi_init_runtime_variable_supported(void) { + efi_status_t ret; u8 s = 0; - int ret; if (!IS_ENABLED(CONFIG_EFI_RT_VOLATILE_STORE)) return EFI_SUCCESS; -- 2.47.3