From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: [PATCH master 2/2] defaultenv: devboot: use rsinit.bind_modules to bind mount modules
Date: Thu, 15 Oct 2026 13:07:01 +0200 [thread overview]
Message-ID: <20261015110703.2378569-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20261015110703.2378569-1-a.fatoum@pengutronix.de>
From: Ahmad Fatoum <a.fatoum@barebox.org>
The rsinit-modules snippet and the devboot documentation pass
rsinit.bind=/lib/modules on the kernel command line, but rsinit only
knows the rsinit.bind_modules flag and silently ignores unknown
options. The modules CPIO is thus unpacked into the initramfs, but
never bind mounted over the root file system's /lib/modules.
Switch both over to rsinit.bind_modules.
Link: https://github.com/pengutronix/rsinit#bind-mounting-kernel-modules-from-initrd
Fixes: 1003a9d70373 ("defaultenv: base: add new devboot script")
Fixes: fc586dda711c ("defaultenv: add optional devboot snippets under /env/devboot/")
Assisted-by: Claude:opus-5.5
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
Documentation/user/devboot.rst | 4 ++--
defaultenv/defaultenv-2-devboot/devboot/rsinit-modules | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/user/devboot.rst b/Documentation/user/devboot.rst
index 28a2f65192d6..a55be7e305f2 100644
--- a/Documentation/user/devboot.rst
+++ b/Documentation/user/devboot.rst
@@ -173,7 +173,7 @@ kernel command line fragments:
devboot_oftree=
devboot_initrd=":afa-modules-arm64"
- global linux.bootargs.devboot.rsinit="rsinit.bind=/lib/modules"
+ global linux.bootargs.devboot.rsinit="rsinit.bind_modules"
With this script in place and ``global.user=afa``, ``global.hostname=rock3a``,
running ``devboot mmc`` on the board expands to::
@@ -222,7 +222,7 @@ which the configuration script can source instead of spelling them out:
``/env/devboot/rsinit-modules``
Appends the ``${global.user}-modules-${global.arch}`` CPIO archive to
the initrd, as built by the Linux kernel ``make modules-cpio-pkg``
- target, and adds ``rsinit.bind=/lib/modules`` to the kernel command
+ target, and adds ``rsinit.bind_modules`` to the kernel command
line, so that the rsinit init in the initramfs bind mounts the modules
over the root file system's ``/lib/modules``.
diff --git a/defaultenv/defaultenv-2-devboot/devboot/rsinit-modules b/defaultenv/defaultenv-2-devboot/devboot/rsinit-modules
index 3ada2dfeac39..b47d2e2739eb 100644
--- a/defaultenv/defaultenv-2-devboot/devboot/rsinit-modules
+++ b/defaultenv/defaultenv-2-devboot/devboot/rsinit-modules
@@ -1,4 +1,4 @@
# Append the module CPIO archive and rsinit bind mount them over /lib/modules
devboot_initrd="${devboot_initrd}:${global.user}-modules-${global.arch}"
-global linux.bootargs.devboot.rsinit="rsinit.bind=/lib/modules"
+global linux.bootargs.devboot.rsinit="rsinit.bind_modules"
--
2.47.3
next prev parent reply other threads:[~2026-10-15 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 11:07 [PATCH master 1/2] defaultenv: bin/devboot: fix typo in final exit Ahmad Fatoum
2026-10-15 11:07 ` Ahmad Fatoum [this message]
2026-10-15 11:40 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015110703.2378569-2-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox