From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: [PATCH] sandbox: console: only look for ^\q on consoles used for input
Date: Thu, 15 Oct 2026 16:04:33 +0200 [thread overview]
Message-ID: <20261015140436.1148772-1-a.fatoum@pengutronix.de> (raw)
From: Ahmad Fatoum <a.fatoum@barebox.org>
The ^\q panic hotkey is checked on every byte any console reads, so a
console whose device file carries binary data, like a future 9P trans_fd,
kills barebox as soon as the two bytes show up in the stream.
Only check consoles that are active for stdin.
Assisted-by: Claude:opus-5.5
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
drivers/serial/linux_console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/serial/linux_console.c b/drivers/serial/linux_console.c
index b8303dfd12ef..6256232d594b 100644
--- a/drivers/serial/linux_console.c
+++ b/drivers/serial/linux_console.c
@@ -38,7 +38,7 @@ static int linux_console_getc(struct console_device *cdev)
linux_read(d->stdinfd, &c, 1);
- if (old_c == 0x1c && c == 'q')
+ if ((cdev->f_active & CONSOLE_STDIN) && old_c == 0x1c && c == 'q')
panic("^\\q pressed - exiting");
old_c = c;
--
2.47.3
reply other threads:[~2026-10-15 14:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015140436.1148772-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox