mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: [PATCH] commands: truncate: report errors from ftruncate()
Date: Thu, 15 Oct 2026 16:08:11 +0200	[thread overview]
Message-ID: <20261015140812.1229929-1-a.fatoum@pengutronix.de> (raw)

From: Ahmad Fatoum <a.fatoum@barebox.org>

ftruncate() and fstat() return a negative error code, not -1, so the
command only noticed an -EPERM and otherwise exited with 0 even when the
file wasn't resized, e.g. on a size ubootvarfs has no room for.

Let's check for any negative return value instead.

Fixes: f59a9574c22c ("commands: add new truncate command")
Assisted-by: Claude:opus-5.5
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
 commands/truncate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/commands/truncate.c b/commands/truncate.c
index 1fd929337dd5..01d827007554 100644
--- a/commands/truncate.c
+++ b/commands/truncate.c
@@ -64,7 +64,7 @@ static int do_truncate(int argc, char *argv[])
 		if (modify) {
 			struct stat st;
 
-			if (fstat(fd, &st) == -1) {
+			if (fstat(fd, &st) < 0) {
 				perror("fstat");
 				ret = 1;
 				close(fd);
@@ -74,7 +74,7 @@ static int do_truncate(int argc, char *argv[])
 			target_size = st.st_size + size;
 		}
 
-		if (ftruncate(fd, target_size) == -1) {
+		if (ftruncate(fd, target_size) < 0) {
 			perror("truncate");
 			ret = 1;
 		}
-- 
2.47.3




                 reply	other threads:[~2026-10-15 14:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261015140812.1229929-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=a.fatoum@barebox.org \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox