From: Sascha Hauer <s.hauer@pengutronix.de>
To: BAREBOX <barebox@lists.infradead.org>
Subject: [PATCH 6/9] fs: symlink: drop references taken by filename_create()
Date: Tue, 20 Oct 2026 09:09:31 +0200 [thread overview]
Message-ID: <20261020-fs-symlink-fixes-v1-6-e7ac8c29b08a@pengutronix.de> (raw)
In-Reply-To: <20261020-fs-symlink-fixes-v1-0-e7ac8c29b08a@pengutronix.de>
symlink() never releases the dentry and the parent path returned by
filename_create(). The leaked vfsmount reference keeps the filesystem
busy, so it can't be unmounted once a symlink has been created on it:
mount -t ramfs none /m
ln -s x /m/l
umount /m -> Device or resource busy
Release both references like mkdirat() and mknodat() do. Also pin the
new dentry in ramfs_symlink() like ramfs_mknod() does, so that symlink
dentries end up with the same reference count as all other ramfs
dentries.
Fixes: b3fbfad7ae ("fs: dentry cache implementation")
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
fs/fs.c | 3 +++
fs/ramfs.c | 1 +
2 files changed, 4 insertions(+)
diff --git a/fs/fs.c b/fs/fs.c
index 40dc32b3c4..dd064c8527 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -2973,6 +2973,9 @@ int symlink(const char *pathname, const char *newpath)
}
error = vfs_symlink(path.dentry->d_inode, dentry, pathname);
+
+ dput(dentry);
+ path_put(&path);
out:
return errno_set(error);
}
diff --git a/fs/ramfs.c b/fs/ramfs.c
index 4c64310e22..22fe620b55 100644
--- a/fs/ramfs.c
+++ b/fs/ramfs.c
@@ -178,6 +178,7 @@ static int ramfs_symlink(struct inode *dir, struct dentry *dentry,
inode->i_link = xstrdup(symname);
inode->i_size = strlen(symname);
d_instantiate(dentry, inode);
+ dget(dentry); /* Extra count - pin the dentry in core */
return 0;
}
--
2.47.3
next prev parent reply other threads:[~2026-10-20 7:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 7:09 [PATCH 0/9] symlink fixes and improvements Sascha Hauer
2026-10-20 7:09 ` [PATCH 1/9] fs: ramfs: report symlink target length as st_size Sascha Hauer
2026-10-20 7:09 ` [PATCH 2/9] fs: qemu_fw_cfg: " Sascha Hauer
2026-10-20 7:09 ` [PATCH 3/9] fs: ramfs: create symlinks with mode 0777 Sascha Hauer
2026-10-20 7:09 ` [PATCH 4/9] fs: follow absolute symlinks from the root directory Sascha Hauer
2026-10-20 7:09 ` [PATCH 5/9] fs: allow trailing symlinks pointing to " Sascha Hauer
2026-10-20 7:09 ` Sascha Hauer [this message]
2026-10-20 7:09 ` [PATCH 7/9] test: self: dirfd: add tests for absolute symlinks Sascha Hauer
2026-10-20 7:09 ` [PATCH 8/9] commands: ln: accept -s option Sascha Hauer
2026-10-20 7:09 ` [PATCH 9/9] commands: ln: create link inside DEST if it is a directory Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020-fs-symlink-fixes-v1-6-e7ac8c29b08a@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox