From: Ahmad Fatoum <a.fatoum@barebox.org>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: [PATCH 2/5] lib: term: ask the terminal when a console can't tell its size
Date: Sun, 8 Nov 2026 10:32:04 +0100 [thread overview]
Message-ID: <20261108093354.1247607-3-a.fatoum@barebox.org> (raw)
In-Reply-To: <20261108093354.1247607-1-a.fatoum@barebox.org>
term_cdev_get_size() returns whatever the get_size callback of a
console returns. A console may not always know its size, though: a
virtio console only does once the host has filled it in. Fall back to
querying the terminal when the callback fails, as for consoles without
one.
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
lib/term.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/term.c b/lib/term.c
index 382250c70ddf..1322546ce8ac 100644
--- a/lib/term.c
+++ b/lib/term.c
@@ -82,8 +82,9 @@ int term_cdev_get_size(struct console_device *cdev,
if (!(cdev->f_active & CONSOLE_STDOUT))
return -ENOENT;
- if (cdev->get_size)
- return cdev->get_size(cdev, screenwidth, screenheight);
+ /* ask the terminal only if the console can't tell size */
+ if (cdev->get_size && !cdev->get_size(cdev, screenwidth, screenheight))
+ return 0;
if (!(cdev->f_active & CONSOLE_STDIN))
return -ENOENT;
--
2.47.3
next prev parent reply other threads:[~2026-11-08 9:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 9:32 [PATCH 0/5] console: escape sequence handling improvement Ahmad Fatoum
2026-11-08 9:32 ` [PATCH 1/5] readkey: wait for the rest of an escape sequence Ahmad Fatoum
2026-11-08 9:32 ` Ahmad Fatoum [this message]
2026-11-08 9:32 ` [PATCH 3/5] serial: virtio_console: report the console size Ahmad Fatoum
2026-11-08 9:32 ` [PATCH 4/5] console: give each console implementation its own console_ctrlc() Ahmad Fatoum
2026-11-08 9:32 ` [PATCH 5/5] console: keep the keys typed ahead when checking for Ctrl-C Ahmad Fatoum
2026-11-09 9:50 ` [PATCH 0/5] console: escape sequence handling improvement Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261108093354.1247607-3-a.fatoum@barebox.org \
--to=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox