mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <sha@pengutronix.de>,
	Marcel Hellwig <barebox+mailing@cookiesoft.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: Heartbeat LED during init script
Date: Thu, 18 Feb 2021 10:01:04 +0100	[thread overview]
Message-ID: <2177a110-305f-98ae-f3bc-f2a9db358143@pengutronix.de> (raw)
In-Reply-To: <20210218083444.GD10569@pengutronix.de>

Helo,

On 18.02.21 09:34, Sascha Hauer wrote:
> On Thu, Feb 18, 2021 at 09:00:42AM +0100, Marcel Hellwig wrote:
>> Hey Sasha,
>>
>> I have a slight problem here:
>> This is what I think:
>>
>> Because the memtest gets called in the init routine, the `ctrl` is
>> completly ignored, at least I can't interrupt it nor the LED blinks.
> 
> Yes, ctrlc() is allowed only after startup. We could move calling
> poller_call() up, before we test if ctrlc is allowed.

I believe that's the correct thing to do.
See my "[PATCH 2/3] console: unconditionally run poller_call in ctrlc()"
from a few days ago. You can cherry pick that now if you like.

> 
>> But if I insert `poller_call`, the led blinks, but the memtest is
>> painfully slow (like 10x slower at least).
> 
> poller_call() takes some time. A solution might be to call poller_call()
> just every thousand times or so in memtest loop.
> 
> Sascha
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2021-02-18  9:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 12:22 barebox+mailing
2021-02-17 12:35 ` Sascha Hauer
2021-02-17 12:44   ` barebox+mailing
2021-02-17 13:17     ` Sascha Hauer
2021-02-18  8:00       ` Marcel Hellwig
2021-02-18  8:34         ` Sascha Hauer
2021-02-18  9:01           ` Ahmad Fatoum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2177a110-305f-98ae-f3bc-f2a9db358143@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox+mailing@cookiesoft.de \
    --cc=barebox@lists.infradead.org \
    --cc=sha@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox