mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] ARM: i.MX: dts: imx93-tqma9352-mba93xxla: add eeprom aliases
Date: Fri, 5 Dec 2025 15:33:29 +0100	[thread overview]
Message-ID: <218f30a8-a711-431b-bcec-92dd89d5428f@pengutronix.de> (raw)
In-Reply-To: <20251205143112.1180264-1-s.hauer@pengutronix.de>

Hi,

On 12/5/25 3:31 PM, Sascha Hauer wrote:
> eeprom0 has an alias in the upstream device tree whereas the other
> EEPROMs have not. Add aliases for the other EEPROMs. Without it the
> other devices will also try to register themselves as eeprom0 which
> fails with -EEXIST.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Should we fix the driver to use dynamic IDs in absence of EEPROMs?

We could use of_alias_get_highest_id() to get a start ID.

Cheers,
Ahmad

> ---
>  arch/arm/dts/imx93-tqma9352-mba93xxla.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/dts/imx93-tqma9352-mba93xxla.dts b/arch/arm/dts/imx93-tqma9352-mba93xxla.dts
> index d1d68a55e1..4b1624cdaa 100644
> --- a/arch/arm/dts/imx93-tqma9352-mba93xxla.dts
> +++ b/arch/arm/dts/imx93-tqma9352-mba93xxla.dts
> @@ -3,3 +3,10 @@
>  #include <arm64/freescale/imx93-tqma9352-mba93xxla.dts>
>  #include "imx93.dtsi"
>  #include "imx93-tqma93xx.dtsi"
> +
> +/ {
> +	aliases {
> +		eeprom1 = &eeprom1;
> +		eeprom2 = &eeprom2;
> +	};
> +};

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |




  reply	other threads:[~2025-12-05 14:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-05 14:31 Sascha Hauer
2025-12-05 14:33 ` Ahmad Fatoum [this message]
2025-12-08 12:02   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=218f30a8-a711-431b-bcec-92dd89d5428f@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox